Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2105553009: Remove declaration of GetCertificateMimeTypeForMimeType. (Closed)

Created:
4 years, 5 months ago by mmenke
Modified:
4 years, 5 months ago
Reviewers:
svaldez
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove declaration of GetCertificateMimeTypeForMimeType. Looks like the function definition was actually removed in https://codereview.chromium.org/1423663012. BUG=514767 Committed: https://crrev.com/00eeb94e3e4c9c6bb78c322b9e3ba49f396af3a3 Cr-Commit-Position: refs/heads/master@{#403018}

Patch Set 1 #

Patch Set 2 : Fix includes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M components/mime_util/mime_util.h View 2 chunks +0 lines, -5 lines 0 comments Download
M components/mime_util/mime_util.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
mmenke
Hope you can find time to review this massive CL. :)
4 years, 5 months ago (2016-06-29 21:06:31 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105553009/40001
4 years, 5 months ago (2016-06-29 22:18:20 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/237011)
4 years, 5 months ago (2016-06-29 23:04:12 UTC) #9
svaldez
Oops, lgtm.
4 years, 5 months ago (2016-06-29 23:37:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105553009/40001
4 years, 5 months ago (2016-06-29 23:41:37 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 5 months ago (2016-06-30 00:21:05 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 00:21:41 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 00:23:19 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/00eeb94e3e4c9c6bb78c322b9e3ba49f396af3a3
Cr-Commit-Position: refs/heads/master@{#403018}

Powered by Google App Engine
This is Rietveld 408576698