Attempt to make probability of test flake in tests/standalone/io/socket_bind_test lower

Attempt to make probability of test flake in tests/standalone/io/socket_bind_test lower

The test is attempting to bind 2 different sockets to the *same* port:
  * socket 1: (IPv4, port)
  * socket 2: (IPv6, port)
Between making socket 1 and socket 2 there can be other processes on the host
grabbing a (IPvX, port) combination thereby making the binding of socket 2 fail.

We will now retry the test a few times which will hopefully make the flakiness
go away.

BUG=https://github.com/dart-lang/sdk/issues/26716
R=whesse@google.com

Committed: https://github.com/dart-lang/sdk/commit/75c8b6d74c5522c56cec9163768eb30608494259

[kustermann, 2016-06-28 10:20:53]

Description was changed from

==========
Attempt to make probability of test flake in
tests/standalone/io/socket_bind_test lower

The test is attempting to bind 2 different sockets to the *same* port:
  * socket 1: (IPv4, port)
  * socket 2: (IPv6, port)
Between making socket 1 and socket 2 there can be other processes on the host
grabbing a (IPvX, port) combination thereby making the binding of socket 2 fail.

We will now retry the test a few times which will hopefully make the flakiness
go away.
==========

to

==========
Attempt to make probability of test flake in
tests/standalone/io/socket_bind_test lower

The test is attempting to bind 2 different sockets to the *same* port:
  * socket 1: (IPv4, port)
  * socket 2: (IPv6, port)
Between making socket 1 and socket 2 there can be other processes on the host
grabbing a (IPvX, port) combination thereby making the binding of socket 2 fail.

We will now retry the test a few times which will hopefully make the flakiness
go away.

BUG=https://github.com/dart-lang/sdk/issues/26716
==========

[kustermann, 2016-06-28 10:21:18]

kustermann@google.com changed reviewers:
+ whesse@google.com

[Bill Hesse, 2016-06-28 10:29:28]

lgtm

https://codereview.chromium.org/2105553003/diff/1/tests/standalone/io/socket_...
File tests/standalone/io/socket_bind_test.dart (right):

https://codereview.chromium.org/2105553003/diff/1/tests/standalone/io/socket_...
tests/standalone/io/socket_bind_test.dart:125: print("Retry $i");
Put the print after the retry-catch block, and print i+1, so that it doesn't
print if there is no retry?

Also, maybe add a message to the print and to the parameters, so it says what it
is retrying?

[kustermann, 2016-06-28 10:36:06]

Thanks

https://codereview.chromium.org/2105553003/diff/1/tests/standalone/io/socket_...
File tests/standalone/io/socket_bind_test.dart (right):

https://codereview.chromium.org/2105553003/diff/1/tests/standalone/io/socket_...
tests/standalone/io/socket_bind_test.dart:125: print("Retry $i");
On 2016/06/28 10:29:28, Bill Hesse wrote:
> Put the print after the retry-catch block, and print i+1, so that it doesn't
> print if there is no retry?
> 
> Also, maybe add a message to the print and to the parameters, so it says what
it
> is retrying?

Done.

[kustermann, 2016-06-28 10:36:26]

Description was changed from

==========
Attempt to make probability of test flake in
tests/standalone/io/socket_bind_test lower

The test is attempting to bind 2 different sockets to the *same* port:
  * socket 1: (IPv4, port)
  * socket 2: (IPv6, port)
Between making socket 1 and socket 2 there can be other processes on the host
grabbing a (IPvX, port) combination thereby making the binding of socket 2 fail.

We will now retry the test a few times which will hopefully make the flakiness
go away.

BUG=https://github.com/dart-lang/sdk/issues/26716
==========

to

==========
Attempt to make probability of test flake in
tests/standalone/io/socket_bind_test lower

The test is attempting to bind 2 different sockets to the *same* port:
  * socket 1: (IPv4, port)
  * socket 2: (IPv6, port)
Between making socket 1 and socket 2 there can be other processes on the host
grabbing a (IPvX, port) combination thereby making the binding of socket 2 fail.

We will now retry the test a few times which will hopefully make the flakiness
go away.

BUG=https://github.com/dart-lang/sdk/issues/26716
R=whesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/75c8b6d74c5522c56cec9163768eb30608494259
==========

[kustermann, 2016-06-28 10:36:27]

Committed patchset #2 (id:20001) manually as
75c8b6d74c5522c56cec9163768eb30608494259 (presubmit successful).