third_party/WebKit/Source/core/frame/TopControls.cpp - Issue 2105523002: Don't set shownRatio in main thread top controls on animated state change.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/TopControls.cpp

Issue 2105523002: Don't set shownRatio in main thread top controls on animated state change. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/frame/TopControls.cpp

diff --git a/third_party/WebKit/Source/core/frame/TopControls.cpp b/third_party/WebKit/Source/core/frame/TopControls.cpp

index d7d3ad90dfcf318d91f96c0cc1e2f5b159f83821..4ebcb0338c02737472a7d15999f89e3df9aa5baa 100644

--- a/third_party/WebKit/Source/core/frame/TopControls.cpp

+++ b/third_party/WebKit/Source/core/frame/TopControls.cpp

@@ -98,11 +98,6 @@ void TopControls::setShownRatio(float shownRatio)

void TopControls::updateConstraints(WebTopControlsState constraints)

{

m_permittedState = constraints;

- if (m_permittedState == WebTopControlsShown)

- setShownRatio(1.f);

- else if (m_permittedState == WebTopControlsHidden)

- setShownRatio(0.f);

}

void TopControls::setHeight(float height, bool shrinkViewport)

« no previous file with comments | « no previous file | third_party/WebKit/Source/web/WebViewImpl.cpp » ('j') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('J')