Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(910)

Unified Diff: third_party/WebKit/Source/platform/network/ResourceRequest.h

Issue 2105503002: Skip foreign fetch when the skipServiceWorker flag is set on a request. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rephrase SkipServiceWorker comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/network/ResourceRequest.h
diff --git a/third_party/WebKit/Source/platform/network/ResourceRequest.h b/third_party/WebKit/Source/platform/network/ResourceRequest.h
index 2a6feae6d8eefd4f99f245fa112306ff320d679c..ffcac5b881ecf7c51f8a66f075a0abdc5569772f 100644
--- a/third_party/WebKit/Source/platform/network/ResourceRequest.h
+++ b/third_party/WebKit/Source/platform/network/ResourceRequest.h
@@ -197,9 +197,9 @@ public:
bool useStreamOnResponse() const { return m_useStreamOnResponse; }
void setUseStreamOnResponse(bool useStreamOnResponse) { m_useStreamOnResponse = useStreamOnResponse; }
- // True if the request should not be handled by the ServiceWorker.
- bool skipServiceWorker() const { return m_skipServiceWorker; }
- void setSkipServiceWorker(bool skipServiceWorker) { m_skipServiceWorker = skipServiceWorker; }
+ // Indicates which types of ServiceWorkers should skip handling this request.
+ WebURLRequest::SkipServiceWorker skipServiceWorker() const { return m_skipServiceWorker; }
+ void setSkipServiceWorker(WebURLRequest::SkipServiceWorker skipServiceWorker) { m_skipServiceWorker = skipServiceWorker; }
// True if corresponding AppCache group should be resetted.
bool shouldResetAppCache() { return m_shouldResetAppCache; }
@@ -267,8 +267,8 @@ private:
bool m_hasUserGesture : 1;
bool m_downloadToFile : 1;
bool m_useStreamOnResponse : 1;
- bool m_skipServiceWorker : 1;
bool m_shouldResetAppCache : 1;
+ WebURLRequest::SkipServiceWorker m_skipServiceWorker;
ResourceLoadPriority m_priority;
int m_intraPriorityValue;
int m_requestorID;
@@ -314,7 +314,7 @@ public:
bool m_reportUploadProgress;
bool m_hasUserGesture;
bool m_downloadToFile;
- bool m_skipServiceWorker;
+ WebURLRequest::SkipServiceWorker m_skipServiceWorker;
bool m_useStreamOnResponse;
bool m_shouldResetAppCache;
ResourceLoadPriority m_priority;

Powered by Google App Engine
This is Rietveld 408576698