Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: content/browser/service_worker/foreign_fetch_request_handler.cc

Issue 2105503002: Skip foreign fetch when the skipServiceWorker flag is set on a request. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rephrase SkipServiceWorker comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/service_worker/foreign_fetch_request_handler.h ('k') | content/child/request_info.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/foreign_fetch_request_handler.cc
diff --git a/content/browser/service_worker/foreign_fetch_request_handler.cc b/content/browser/service_worker/foreign_fetch_request_handler.cc
index d446aa64e76c68ee50fbdda24a7683242b0fbd3c..068e3fab304ac5131089500c54fe9e2428bfd8e0 100644
--- a/content/browser/service_worker/foreign_fetch_request_handler.cc
+++ b/content/browser/service_worker/foreign_fetch_request_handler.cc
@@ -51,7 +51,7 @@ void ForeignFetchRequestHandler::InitializeHandler(
storage::BlobStorageContext* blob_storage_context,
int process_id,
int provider_id,
- bool skip_service_worker,
+ SkipServiceWorker skip_service_worker,
FetchRequestMode request_mode,
FetchCredentialsMode credentials_mode,
FetchRedirectMode redirect_mode,
@@ -60,9 +60,11 @@ void ForeignFetchRequestHandler::InitializeHandler(
RequestContextFrameType frame_type,
scoped_refptr<ResourceRequestBodyImpl> body,
bool initiated_in_secure_context) {
- if (!context_wrapper) {
+ if (!context_wrapper)
+ return;
+
+ if (skip_service_worker == SkipServiceWorker::ALL)
return;
- }
if (!initiated_in_secure_context)
return;
« no previous file with comments | « content/browser/service_worker/foreign_fetch_request_handler.h ('k') | content/child/request_info.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698