content/common/resource_request.h - Issue 2105503002: Skip foreign fetch when the skipServiceWorker flag is set on a request.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/resource_request.h

Issue 2105503002: Skip foreign fetch when the skipServiceWorker flag is set on a request. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add comments explaing why skip is set to ::Controlling for fallback requests Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/resource_messages.h ('k') | content/common/service_worker/service_worker_types.h » ('j') | content/common/service_worker/service_worker_types.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/resource_request.h

diff --git a/content/common/resource_request.h b/content/common/resource_request.h

index c7b158f46af73ed0fff920e6c197826537c18e01..2e5161e320b684d97a884484fe2ecaecf7722b4b 100644

--- a/content/common/resource_request.h

+++ b/content/common/resource_request.h

@@ -93,8 +93,8 @@ struct CONTENT_EXPORT ResourceRequest {

// fetch() in the Service Worker script.

bool originated_from_service_worker = false;

- // True if the request should not be handled by the ServiceWorker.

- bool skip_service_worker = false;

+ // Whether or not the request should be handled by a ServiceWorker.

+ SkipServiceWorker skip_service_worker = SkipServiceWorker::NONE;

// The request mode passed to the ServiceWorker.

FetchRequestMode fetch_request_mode = FETCH_REQUEST_MODE_SAME_ORIGIN;