content/browser/service_worker/foreign_fetch_request_handler.cc - Issue 2105503002: Skip foreign fetch when the skipServiceWorker flag is set on a request.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/foreign_fetch_request_handler.cc

Issue 2105503002: Skip foreign fetch when the skipServiceWorker flag is set on a request. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add comments explaing why skip is set to ::Controlling for fallback requests Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/foreign_fetch_request_handler.h ('k') | content/child/request_info.h » ('j') | content/common/service_worker/service_worker_types.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/foreign_fetch_request_handler.cc

diff --git a/content/browser/service_worker/foreign_fetch_request_handler.cc b/content/browser/service_worker/foreign_fetch_request_handler.cc

index d446aa64e76c68ee50fbdda24a7683242b0fbd3c..068e3fab304ac5131089500c54fe9e2428bfd8e0 100644

--- a/content/browser/service_worker/foreign_fetch_request_handler.cc

+++ b/content/browser/service_worker/foreign_fetch_request_handler.cc

@@ -51,7 +51,7 @@ void ForeignFetchRequestHandler::InitializeHandler(

storage::BlobStorageContext* blob_storage_context,

int process_id,

int provider_id,

- bool skip_service_worker,

+ SkipServiceWorker skip_service_worker,

FetchRequestMode request_mode,

FetchCredentialsMode credentials_mode,

FetchRedirectMode redirect_mode,

@@ -60,9 +60,11 @@ void ForeignFetchRequestHandler::InitializeHandler(

RequestContextFrameType frame_type,

scoped_refptr<ResourceRequestBodyImpl> body,

bool initiated_in_secure_context) {

- if (!context_wrapper) {

+ if (!context_wrapper)

+ return;

+ if (skip_service_worker == SkipServiceWorker::ALL)

return;

- }

if (!initiated_in_secure_context)

return;