Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: content/browser/loader/resource_dispatcher_host_impl.cc

Issue 2105503002: Skip foreign fetch when the skipServiceWorker flag is set on a request. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add comments explaing why skip is set to ::Controlling for fallback requests Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/resource_dispatcher_host_impl.cc
diff --git a/content/browser/loader/resource_dispatcher_host_impl.cc b/content/browser/loader/resource_dispatcher_host_impl.cc
index e3d759daf105eb09c0b52f61250e18d4cb76887a..59fc5d2ec1d022cf570f84f1a00837e546eb0f9b 100644
--- a/content/browser/loader/resource_dispatcher_host_impl.cc
+++ b/content/browser/loader/resource_dispatcher_host_impl.cc
@@ -1567,12 +1567,12 @@ void ResourceDispatcherHostImpl::BeginRequest(
// Initialize the service worker handler for the request. We don't use
// ServiceWorker for synchronous loads to avoid renderer deadlocks.
- const bool should_skip_service_worker =
- request_data.skip_service_worker || is_sync_load;
+ const SkipServiceWorker should_skip_service_worker =
+ is_sync_load ? SkipServiceWorker::ALL : request_data.skip_service_worker;
ServiceWorkerRequestHandler::InitializeHandler(
new_request.get(), filter_->service_worker_context(), blob_context,
child_id, request_data.service_worker_provider_id,
- should_skip_service_worker,
+ should_skip_service_worker != SkipServiceWorker::NONE,
request_data.fetch_request_mode, request_data.fetch_credentials_mode,
request_data.fetch_redirect_mode, request_data.resource_type,
request_data.fetch_request_context_type, request_data.fetch_frame_type,
@@ -1583,11 +1583,11 @@ void ResourceDispatcherHostImpl::BeginRequest(
ForeignFetchRequestHandler::InitializeHandler(
new_request.get(), filter_->service_worker_context(), blob_context,
child_id, request_data.service_worker_provider_id,
- should_skip_service_worker,
- request_data.fetch_request_mode, request_data.fetch_credentials_mode,
- request_data.fetch_redirect_mode, request_data.resource_type,
- request_data.fetch_request_context_type, request_data.fetch_frame_type,
- request_data.request_body, request_data.initiated_in_secure_context);
+ should_skip_service_worker, request_data.fetch_request_mode,
+ request_data.fetch_credentials_mode, request_data.fetch_redirect_mode,
+ request_data.resource_type, request_data.fetch_request_context_type,
+ request_data.fetch_frame_type, request_data.request_body,
+ request_data.initiated_in_secure_context);
}
// Have the appcache associate its extra info with the request.

Powered by Google App Engine
This is Rietveld 408576698