Skip foreign fetch when the skipServiceWorker flag is set on a request.

content/child/web_url_loader_impl.cc

Index: content/child/web_url_loader_impl.cc
diff --git a/content/child/web_url_loader_impl.cc b/content/child/web_url_loader_impl.cc
index 80741405a603c8aa25d3e9c085b4b2d7bac65033..e31a16a2bc506a9b2f470bf7b6bd707ecc0a66bc 100644
--- a/content/child/web_url_loader_impl.cc
+++ b/content/child/web_url_loader_impl.cc
@@ -506,7 +506,8 @@ void WebURLLoaderImpl::Context::Start(const WebURLRequest& request,
   request_info.routing_id = request.requestorID();
   request_info.download_to_file = request.downloadToFile();
   request_info.has_user_gesture = request.hasUserGesture();
-  request_info.skip_service_worker = request.skipServiceWorker();
+  request_info.skip_service_worker =
+      GetSkipServiceWorkerForWebURLRequest(request);
   request_info.should_reset_appcache = request.shouldResetAppCache();
   request_info.fetch_request_mode =
       GetFetchRequestModeForWebURLRequest(request);
@@ -580,9 +581,12 @@ bool WebURLLoaderImpl::Context::OnReceivedRedirect(
 
   WebURLRequest new_request;
   new_request.initialize();
-  PopulateURLRequestForRedirect(request_, redirect_info, referrer_policy_,
-                                !info.was_fetched_via_service_worker,
-                                &new_request);
+  PopulateURLRequestForRedirect(
+      request_, redirect_info, referrer_policy_,
+      info.was_fetched_via_service_worker
+          ? blink::WebURLRequest::SkipServiceWorker::None
+          : blink::WebURLRequest::SkipServiceWorker::All,

[horo, 2016/06/28 12:10:02]

What should happen in this case?
1. https://example1.com is controlled by a Service Worker (SW1).
2. <img src="//example2.com/test.png"> in https://example1.com.
3. SW1 doesn't call respondWith() for the request.
4. The server (example2.com) returns a redirect response (Location:
https://example3.com/test.png).
5. example3.com has a foreign fetch Service Worker (SW2).

Should the fetch handler of SW2 be fired?

[Marijn Kruisselbrink, 2016/06/28 17:06:12]

This reminds me that I still need to write the integration with the fetch spec
for foreign fetch. But no, I think at least initially I don't think servers
redirecting should ever end up back in a service worker (in other worse, I'm
planning on using the same "skip-service-worker-flag" the fetch spec uses to
skip regular service workers to also skip foreign fetch service workers; fetch
always sets that flag on requests that weren't initially handled by a service
worker, so no redirects will end up being handled by a service worker).

+      &new_request);
 
   client_->willFollowRedirect(loader_, new_request, response);
   request_ = new_request;
@@ -1072,7 +1076,7 @@ void WebURLLoaderImpl::PopulateURLRequestForRedirect(
     const blink::WebURLRequest& request,
     const net::RedirectInfo& redirect_info,
     blink::WebReferrerPolicy referrer_policy,
-    bool skip_service_worker,
+    blink::WebURLRequest::SkipServiceWorker skip_service_worker,
     blink::WebURLRequest* new_request) {
   // TODO(darin): We lack sufficient information to construct the actual
   // request that resulted from the redirect.