Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: third_party/WebKit/Source/modules/fetch/FetchManager.cpp

Issue 2105503002: Skip foreign fetch when the skipServiceWorker flag is set on a request. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rephrase SkipServiceWorker comments. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/fetch/FetchManager.h" 5 #include "modules/fetch/FetchManager.h"
6 6
7 #include "bindings/core/v8/ExceptionState.h" 7 #include "bindings/core/v8/ExceptionState.h"
8 #include "bindings/core/v8/ScriptPromiseResolver.h" 8 #include "bindings/core/v8/ScriptPromiseResolver.h"
9 #include "bindings/core/v8/ScriptState.h" 9 #include "bindings/core/v8/ScriptState.h"
10 #include "bindings/core/v8/V8ThrowException.h" 10 #include "bindings/core/v8/V8ThrowException.h"
(...skipping 570 matching lines...) Expand 10 before | Expand all | Expand 10 after
581 // is none, and `Referer`/|HTTPRequest|'s referrer, serialized and utf-8 581 // is none, and `Referer`/|HTTPRequest|'s referrer, serialized and utf-8
582 // encoded, otherwise, to HTTPRequest's header list. 582 // encoded, otherwise, to HTTPRequest's header list.
583 // 583 //
584 // The following code also invokes "determine request's referrer" which is 584 // The following code also invokes "determine request's referrer" which is
585 // written in "Main fetch" operation. 585 // written in "Main fetch" operation.
586 const ReferrerPolicy referrerPolicy = m_request->getReferrerPolicy() == Refe rrerPolicyDefault ? m_executionContext->getReferrerPolicy() : m_request->getRefe rrerPolicy(); 586 const ReferrerPolicy referrerPolicy = m_request->getReferrerPolicy() == Refe rrerPolicyDefault ? m_executionContext->getReferrerPolicy() : m_request->getRefe rrerPolicy();
587 const String referrerString = m_request->referrerString() == FetchRequestDat a::clientReferrerString() ? m_executionContext->outgoingReferrer() : m_request-> referrerString(); 587 const String referrerString = m_request->referrerString() == FetchRequestDat a::clientReferrerString() ? m_executionContext->outgoingReferrer() : m_request-> referrerString();
588 // Note that generateReferrer generates |no-referrer| from |no-referrer| 588 // Note that generateReferrer generates |no-referrer| from |no-referrer|
589 // referrer string (i.e. String()). 589 // referrer string (i.e. String()).
590 request.setHTTPReferrer(SecurityPolicy::generateReferrer(referrerPolicy, m_r equest->url(), referrerString)); 590 request.setHTTPReferrer(SecurityPolicy::generateReferrer(referrerPolicy, m_r equest->url(), referrerString));
591 request.setSkipServiceWorker(m_isIsolatedWorld); 591 request.setSkipServiceWorker(m_isIsolatedWorld ? WebURLRequest::SkipServiceW orker::All : WebURLRequest::SkipServiceWorker::None);
592 592
593 // "3. Append `Host`, ..." 593 // "3. Append `Host`, ..."
594 // FIXME: Implement this when the spec is fixed. 594 // FIXME: Implement this when the spec is fixed.
595 595
596 // "4.If |HTTPRequest|'s force Origin header flag is set, append `Origin`/ 596 // "4.If |HTTPRequest|'s force Origin header flag is set, append `Origin`/
597 // |HTTPRequest|'s origin, serialized and utf-8 encoded, to |HTTPRequest|'s 597 // |HTTPRequest|'s origin, serialized and utf-8 encoded, to |HTTPRequest|'s
598 // header list." 598 // header list."
599 // We set Origin header in updateRequestForAccessControl() called from 599 // We set Origin header in updateRequestForAccessControl() called from
600 // DocumentThreadableLoader::makeCrossOriginAccessRequest 600 // DocumentThreadableLoader::makeCrossOriginAccessRequest
601 601
(...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after
738 loader->dispose(); 738 loader->dispose();
739 } 739 }
740 740
741 DEFINE_TRACE(FetchManager) 741 DEFINE_TRACE(FetchManager)
742 { 742 {
743 visitor->trace(m_loaders); 743 visitor->trace(m_loaders);
744 ContextLifecycleObserver::trace(visitor); 744 ContextLifecycleObserver::trace(visitor);
745 } 745 }
746 746
747 } // namespace blink 747 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698