Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1959)

Side by Side Diff: content/renderer/render_frame_impl.cc

Issue 2105503002: Skip foreign fetch when the skipServiceWorker flag is set on a request. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rephrase SkipServiceWorker comments. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/render_frame_impl.h" 5 #include "content/renderer/render_frame_impl.h"
6 6
7 #include <map> 7 #include <map>
8 #include <string> 8 #include <string>
9 #include <utility> 9 #include <utility>
10 #include <vector> 10 #include <vector>
(...skipping 4009 matching lines...) Expand 10 before | Expand all | Expand 10 after
4020 provider_id = provider->provider_id(); 4020 provider_id = provider->provider_id();
4021 } 4021 }
4022 } else if (frame->dataSource()) { 4022 } else if (frame->dataSource()) {
4023 ServiceWorkerNetworkProvider* provider = 4023 ServiceWorkerNetworkProvider* provider =
4024 ServiceWorkerNetworkProvider::FromDocumentState( 4024 ServiceWorkerNetworkProvider::FromDocumentState(
4025 DocumentState::FromDataSource(frame->dataSource())); 4025 DocumentState::FromDataSource(frame->dataSource()));
4026 DCHECK(provider); 4026 DCHECK(provider);
4027 provider_id = provider->provider_id(); 4027 provider_id = provider->provider_id();
4028 // Explicitly set the SkipServiceWorker flag here if the renderer process 4028 // Explicitly set the SkipServiceWorker flag here if the renderer process
4029 // hasn't received SetControllerServiceWorker message. 4029 // hasn't received SetControllerServiceWorker message.
4030 if (!provider->IsControlledByServiceWorker()) 4030 if (!provider->IsControlledByServiceWorker() &&
4031 request.setSkipServiceWorker(true); 4031 request.skipServiceWorker() !=
4032 blink::WebURLRequest::SkipServiceWorker::All)
4033 request.setSkipServiceWorker(
4034 blink::WebURLRequest::SkipServiceWorker::Controlling);
4032 } 4035 }
4033 4036
4034 WebFrame* parent = frame->parent(); 4037 WebFrame* parent = frame->parent();
4035 int parent_routing_id = parent ? GetRoutingIdForFrameOrProxy(parent) : -1; 4038 int parent_routing_id = parent ? GetRoutingIdForFrameOrProxy(parent) : -1;
4036 4039
4037 RequestExtraData* extra_data = new RequestExtraData(); 4040 RequestExtraData* extra_data = new RequestExtraData();
4038 extra_data->set_visibility_state(visibilityState()); 4041 extra_data->set_visibility_state(visibilityState());
4039 extra_data->set_custom_user_agent(custom_user_agent); 4042 extra_data->set_custom_user_agent(custom_user_agent);
4040 extra_data->set_requested_with(requested_with); 4043 extra_data->set_requested_with(requested_with);
4041 extra_data->set_render_frame_id(routing_id_); 4044 extra_data->set_render_frame_id(routing_id_);
(...skipping 1778 matching lines...) Expand 10 before | Expand all | Expand 10 after
5820 DCHECK(!frame_->parent() || 5823 DCHECK(!frame_->parent() ||
5821 GetRequestContextFrameTypeForWebURLRequest(*request) == 5824 GetRequestContextFrameTypeForWebURLRequest(*request) ==
5822 REQUEST_CONTEXT_FRAME_TYPE_NESTED); 5825 REQUEST_CONTEXT_FRAME_TYPE_NESTED);
5823 5826
5824 Send(new FrameHostMsg_BeginNavigation( 5827 Send(new FrameHostMsg_BeginNavigation(
5825 routing_id_, 5828 routing_id_,
5826 MakeCommonNavigationParams(request, should_replace_current_entry), 5829 MakeCommonNavigationParams(request, should_replace_current_entry),
5827 BeginNavigationParams(GetWebURLRequestHeaders(*request), 5830 BeginNavigationParams(GetWebURLRequestHeaders(*request),
5828 GetLoadFlagsForWebURLRequest(*request), 5831 GetLoadFlagsForWebURLRequest(*request),
5829 request->hasUserGesture(), 5832 request->hasUserGesture(),
5830 request->skipServiceWorker(), 5833 request->skipServiceWorker() !=
5834 blink::WebURLRequest::SkipServiceWorker::None,
5831 GetRequestContextTypeForWebURLRequest(*request)))); 5835 GetRequestContextTypeForWebURLRequest(*request))));
5832 } 5836 }
5833 5837
5834 void RenderFrameImpl::LoadDataURL( 5838 void RenderFrameImpl::LoadDataURL(
5835 const CommonNavigationParams& params, 5839 const CommonNavigationParams& params,
5836 const RequestNavigationParams& request_params, 5840 const RequestNavigationParams& request_params,
5837 WebLocalFrame* frame, 5841 WebLocalFrame* frame,
5838 blink::WebFrameLoadType load_type, 5842 blink::WebFrameLoadType load_type,
5839 blink::WebHistoryItem item_for_history_navigation, 5843 blink::WebHistoryItem item_for_history_navigation,
5840 blink::WebHistoryLoadType history_load_type, 5844 blink::WebHistoryLoadType history_load_type,
(...skipping 469 matching lines...) Expand 10 before | Expand all | Expand 10 after
6310 // event target. Potentially a Pepper plugin will receive the event. 6314 // event target. Potentially a Pepper plugin will receive the event.
6311 // In order to tell whether a plugin gets the last mouse event and which it 6315 // In order to tell whether a plugin gets the last mouse event and which it
6312 // is, we set |pepper_last_mouse_event_target_| to null here. If a plugin gets 6316 // is, we set |pepper_last_mouse_event_target_| to null here. If a plugin gets
6313 // the event, it will notify us via DidReceiveMouseEvent() and set itself as 6317 // the event, it will notify us via DidReceiveMouseEvent() and set itself as
6314 // |pepper_last_mouse_event_target_|. 6318 // |pepper_last_mouse_event_target_|.
6315 pepper_last_mouse_event_target_ = nullptr; 6319 pepper_last_mouse_event_target_ = nullptr;
6316 #endif 6320 #endif
6317 } 6321 }
6318 6322
6319 } // namespace content 6323 } // namespace content
OLDNEW
« no previous file with comments | « content/renderer/pepper/pepper_url_loader_host.cc ('k') | content/renderer/shared_worker/embedded_shared_worker_stub.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698