Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1048)

Unified Diff: printing/backend/print_backend_chromeos.cc

Issue 2105463002: Create a new print backend for the updated CUPS APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix printing gyp file. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: printing/backend/print_backend_chromeos.cc
diff --git a/printing/backend/print_backend_chromeos.cc b/printing/backend/print_backend_chromeos.cc
index 35f51b7ec6085e53069e76f3ad61971fe4009a1a..51bdacb7deb0f18a6411db500a93d5fa56c5a012 100644
--- a/printing/backend/print_backend_chromeos.cc
+++ b/printing/backend/print_backend_chromeos.cc
@@ -1,4 +1,4 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Copyright 2016 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -10,7 +10,7 @@
#include "url/gurl.h"
#if defined(USE_CUPS)
-#include "printing/backend/print_backend_cups.h"
+#include "printing/backend/print_backend_cups_ipp.h"
#endif // defined(USE_CUPS)
namespace printing {
@@ -93,9 +93,12 @@ scoped_refptr<PrintBackend> PrintBackend::CreateInstance(
print_backend_settings->GetInteger(kCUPSEncryption, &encryption);
}
GURL print_server_url(print_server_url_str.c_str());
- return new PrintBackendCUPS(print_server_url,
- static_cast<http_encryption_t>(encryption),
- cups_blocking == kValueTrue);
+
+ CupsConnection connection(print_server_url,
Lei Zhang 2016/07/13 01:08:43 This should be an unique_ptr, and PrintBackendCups
skau 2016/07/14 20:43:06 Thanks. I somehow missed that in the style guide.
+ static_cast<http_encryption_t>(encryption),
+ cups_blocking == kValueTrue);
+
+ return new PrintBackendCupsIpp(std::move(connection));
#endif // defined(USE_CUPS)
}

Powered by Google App Engine
This is Rietveld 408576698