Create a new print backend for the updated CUPS APIs

printing/printing.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'chromium_code': 1,
   },
   'targets': [
     {
@@ skipping 54 matching lines @@
         'print_settings.cc',
         'print_settings.h',
         'print_settings_conversion.cc',
         'print_settings_conversion.h',
         'print_settings_initializer_mac.cc',
         'print_settings_initializer_mac.h',
         'print_settings_initializer_win.cc',
         'print_settings_initializer_win.h',
         'printed_document.cc',
         'printed_document.h',
-        'printed_document_linux.cc',
         'printed_document_mac.cc',
         'printed_document_win.cc',
         'printed_page.cc',
         'printed_page.h',
         'printed_pages_source.h',
         'printing_context.cc',
         'printing_context.h',
         'printing_context_system_dialog_win.cc',
         'printing_context_system_dialog_win.h',
         'printing_context_win.cc',
@@ skipping 81 matching lines @@
                   '-Wno-deprecated-declarations',
                 ],
               },
             }],
           ],
           'defines': [
             # PRINT_BACKEND_AVAILABLE disables the default dummy implementation
             # of the print backend and enables a custom implementation instead.
             'PRINT_BACKEND_AVAILABLE',
           ],
-          'sources': [
-            'backend/cups_helper.cc',
-            'backend/cups_helper.h',
-            'backend/print_backend_cups.cc',
+
+          'conditions': [

[Lei Zhang, 2016/07/13 00:34:27]

I think the redness means you have tabs, and not spaces.

[skau, 2016/07/14 20:43:06]

Done.

+            ['chromeos==1', {
+              'sources': [
+                'backend/cups_connection.cc',
+                'backend/cups_connection.h',
+                'backend/cups_ipp_util.cc',
+                'backend/cups_ipp_util.h',
+                'backend/cups_printer.cc',
+                'backend/cups_printer.h',
+                'backend/print_backend_cups_ipp.cc',
+                'backend/print_backend_cups_ipp.h',
+              ],
+            }],

[Lei Zhang, 2016/07/13 00:34:27]

GYP can do if-else:

['chromeos==1', {
  ...
}, {
  ... # else case
}],

[skau, 2016/07/14 20:43:06]

I didn't see that.  Thanks.

+            ['chromeos==0', {
+              'sources': [
+                'backend/cups_helper.cc',
+                'backend/cups_helper.h',
+                'backend/print_backend_cups.cc',
+              ],
+            }]
           ],
         }],
         ['OS=="linux" and chromeos==1', {
           'defines': [
             # PRINT_BACKEND_AVAILABLE disables the default dummy implementation
             # of the print backend and enables a custom implementation instead.
             'PRINT_BACKEND_AVAILABLE',
           ],
           'sources': [
             'backend/print_backend_chromeos.cc',
           ],
         }],
         ['OS=="linux" and chromeos==0', {
           'sources': [
             'printing_context_linux.cc',
             'printing_context_linux.h',
+            'printed_document_linux.cc',

[Lei Zhang, 2016/07/13 00:34:27]

alphabetical order

[skau, 2016/07/14 20:43:06]

Done.

           ],
         }],
         ['OS=="android"', {
           'sources': [
             'printing_context_android.cc',
             'printing_context_android.h',
           ],
           'dependencies': [
             'printing_jni_headers',
           ],
@@ skipping 124 matching lines @@
             '../build/isolate.gypi',
           ],
           'sources': [
             'printing_unittests.isolate',
           ],
         },
       ],
     }],
   ]
 }