Create a new print backend for the updated CUPS APIs

printing/backend/print_backend_chromeos.cc

-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "printing/backend/print_backend.h"
 
 #include "base/logging.h"
 #include "base/values.h"
 #include "printing/backend/print_backend_consts.h"
 #include "url/gurl.h"
 
 #if defined(USE_CUPS)
-#include "printing/backend/print_backend_cups.h"
+#include "printing/backend/print_backend_cups_ipp.h"
 #endif  // defined(USE_CUPS)
 
 namespace printing {
 
 // Provides a stubbed out PrintBackend implementation for use on ChromeOS.

[Lei Zhang, 2016/07/13 01:08:43]

Update comment.

[skau, 2016/07/14 20:43:06]

Done.

 class PrintBackendChromeOS : public PrintBackend {
  public:
   PrintBackendChromeOS();
 
   // PrintBackend implementation.
   bool EnumeratePrinters(PrinterList* printer_list) override;
   std::string GetDefaultPrinterName() override;
   bool GetPrinterBasicInfo(const std::string& printer_name,
                            PrinterBasicInfo* printer_info) override;
   bool GetPrinterSemanticCapsAndDefaults(
@@ skipping 57 matching lines @@
     int encryption = HTTP_ENCRYPT_NEVER;
     if (print_backend_settings) {
       print_backend_settings->GetString(kCUPSPrintServerURL,
                                         &print_server_url_str);
 
       print_backend_settings->GetString(kCUPSBlocking, &cups_blocking);
 
       print_backend_settings->GetInteger(kCUPSEncryption, &encryption);
     }
     GURL print_server_url(print_server_url_str.c_str());
-    return new PrintBackendCUPS(print_server_url,
-                                static_cast<http_encryption_t>(encryption),
-                                cups_blocking == kValueTrue);
+
+    CupsConnection connection(print_server_url,

[Lei Zhang, 2016/07/13 01:08:43]

This should be an unique_ptr, and PrintBackendCupsIpp should store an
unique_ptr. https://google.github.io/styleguide/cppguide.html#Rvalue_references

[skau, 2016/07/14 20:43:06]

Thanks.  I somehow missed that in the style guide.

+                              static_cast<http_encryption_t>(encryption),
+                              cups_blocking == kValueTrue);
+
+    return new PrintBackendCupsIpp(std::move(connection));
 #endif  // defined(USE_CUPS)
   }
 
   return new PrintBackendChromeOS();
 }
 
 }  // namespace printing