Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 210543002: Removed pinch viewport scroll offset distribution (Closed)

Created:
6 years, 9 months ago by bokan
Modified:
6 years, 8 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

Removed pinch viewport scroll offset distribution The associated change in Blink makes the pinch viewport a proper ScrollableArea meaning the normal path for synchronizing layer scroll offsets is used. This is a 2 sided patch, the other CL: https://codereview.chromium.org/199253002/ BUG=349941 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260105

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -175 lines) Patch
M cc/cc_tests.gyp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/layer.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_host.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 1 chunk +0 lines, -44 lines 0 comments Download
D cc/trees/layer_tree_host_unittest_pinch_zoom.cc View 1 2 1 chunk +0 lines, -122 lines 0 comments Download

Messages

Total messages: 35 (0 generated)
bokan
6 years, 9 months ago (2014-03-24 23:35:15 UTC) #1
aelias_OOO_until_Jul13
https://codereview.chromium.org/210543002/diff/1/cc/layers/layer.cc File cc/layers/layer.cc (right): https://codereview.chromium.org/210543002/diff/1/cc/layers/layer.cc#newcode682 cc/layers/layer.cc:682: scroll_offset = layer_tree_host()->DistributeScrollOffsetToViewports( It looks like this method just ...
6 years, 9 months ago (2014-03-25 00:09:23 UTC) #2
bokan
On 2014/03/25 00:09:23, aelias wrote: > https://codereview.chromium.org/210543002/diff/1/cc/layers/layer.cc > File cc/layers/layer.cc (right): > > https://codereview.chromium.org/210543002/diff/1/cc/layers/layer.cc#newcode682 > ...
6 years, 9 months ago (2014-03-25 00:22:20 UTC) #3
aelias_OOO_until_Jul13
lgtm
6 years, 9 months ago (2014-03-25 00:27:33 UTC) #4
bokan
The CQ bit was checked by bokan@chromium.org
6 years, 9 months ago (2014-03-27 12:36:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bokan@chromium.org/210543002/20001
6 years, 9 months ago (2014-03-27 12:36:44 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 14:03:36 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_chromium_rel
6 years, 9 months ago (2014-03-27 14:03:37 UTC) #8
bokan
The CQ bit was checked by bokan@chromium.org
6 years, 9 months ago (2014-03-27 14:22:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bokan@chromium.org/210543002/40001
6 years, 9 months ago (2014-03-27 14:23:03 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-27 14:47:33 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg tryserver.chromium on linux_chromium_rel
6 years, 8 months ago (2014-03-27 14:47:34 UTC) #12
bokan
The CQ bit was checked by bokan@chromium.org
6 years, 8 months ago (2014-03-27 14:57:31 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bokan@chromium.org/210543002/40001
6 years, 8 months ago (2014-03-27 14:57:49 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-27 15:17:02 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_clang_dbg
6 years, 8 months ago (2014-03-27 15:17:03 UTC) #16
bokan
The CQ bit was checked by bokan@chromium.org
6 years, 8 months ago (2014-03-27 15:42:11 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bokan@chromium.org/210543002/40001
6 years, 8 months ago (2014-03-27 15:42:23 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-27 15:53:57 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_clang_dbg
6 years, 8 months ago (2014-03-27 15:53:58 UTC) #20
bokan
The CQ bit was checked by bokan@chromium.org
6 years, 8 months ago (2014-03-27 16:33:39 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bokan@chromium.org/210543002/40001
6 years, 8 months ago (2014-03-27 16:35:43 UTC) #22
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-27 16:42:37 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-03-27 16:42:37 UTC) #24
bokan
The CQ bit was checked by bokan@chromium.org
6 years, 8 months ago (2014-03-27 18:18:13 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bokan@chromium.org/210543002/40001
6 years, 8 months ago (2014-03-27 18:19:23 UTC) #26
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-27 20:53:03 UTC) #27
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=289627
6 years, 8 months ago (2014-03-27 20:53:04 UTC) #28
bokan
The CQ bit was checked by bokan@chromium.org
6 years, 8 months ago (2014-03-27 21:01:56 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bokan@chromium.org/210543002/40001
6 years, 8 months ago (2014-03-27 21:05:01 UTC) #30
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-27 22:29:09 UTC) #31
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 8 months ago (2014-03-27 22:29:09 UTC) #32
bokan
The CQ bit was checked by bokan@chromium.org
6 years, 8 months ago (2014-03-28 11:20:39 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bokan@chromium.org/210543002/40001
6 years, 8 months ago (2014-03-28 11:22:04 UTC) #34
commit-bot: I haz the power
6 years, 8 months ago (2014-03-28 11:24:21 UTC) #35
Message was sent while issue was closed.
Change committed as 260105

Powered by Google App Engine
This is Rietveld 408576698