Issue 2105383003: VM: Don't generate allocation stats code in product mode.

Issue 2105383003: VM: Don't generate allocation stats code in product mode. (Closed)

Created:
4 years, 5 months ago by Florian Schneider

Modified:
4 years, 5 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

VM: Don't generate allocation stats code in product mode. They are not needed since there is no observatory/profiling support in product mode. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/46f8b02dbb0a648f0e2f2a331a079fa319717c7f

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+87 lines, -83 lines)			Patch
M	runtime/vm/assembler_arm.cc	View	6 chunks	+7 lines, -6 lines	0 comments	Download
M	runtime/vm/assembler_arm64.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	runtime/vm/assembler_ia32.cc	View	4 chunks	+6 lines, -4 lines	0 comments	Download
M	runtime/vm/assembler_mips.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	runtime/vm/assembler_x64.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	runtime/vm/class_table.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/intrinsifier_arm.cc	View	6 chunks	+6 lines, -6 lines	0 comments	Download
M	runtime/vm/intrinsifier_arm64.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	runtime/vm/intrinsifier_ia32.cc	View	4 chunks	+5 lines, -4 lines	0 comments	Download
M	runtime/vm/intrinsifier_mips.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	runtime/vm/intrinsifier_x64.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	runtime/vm/stub_code_arm.cc	View	8 chunks	+8 lines, -8 lines	0 comments	Download
M	runtime/vm/stub_code_arm64.cc	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View	5 chunks	+11 lines, -11 lines	0 comments	Download
M	runtime/vm/stub_code_mips.cc	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View	5 chunks	+9 lines, -9 lines	0 comments	Download

Total messages: 6 (2 generated)

rmacnak

LGTM We should also be able to avoid allocating the stats tables.

4 years, 5 months ago (2016-06-30 16:56:56 UTC) #3

Florian Schneider

On 2016/06/30 16:56:56, rmacnak wrote: > LGTM > > We should also be able to ...

4 years, 5 months ago (2016-06-30 17:14:38 UTC) #4

Florian Schneider

4 years, 5 months ago (2016-06-30 20:35:47 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
46f8b02dbb0a648f0e2f2a331a079fa319717c7f (presubmit successful).