Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2105383002: Use a converter for -webkit-clip-path (Closed)

Created:
4 years, 5 months ago by fs
Modified:
4 years, 5 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@move-clippathop
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use a converter for -webkit-clip-path Add StyleBuilderConverter::convertClipPath and use it for computing the ClipPathOperation. BUG=610854 Committed: https://crrev.com/8d8d4c8cd2fa6ed3357d7902bdf5adbeea471369 Cr-Commit-Position: refs/heads/master@{#403153}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -25 lines) Patch
M third_party/WebKit/Source/core/css/CSSProperties.in View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp View 1 2 chunks +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp View 2 chunks +0 lines, -22 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
fs
4 years, 5 months ago (2016-06-29 20:05:59 UTC) #2
Timothy Loh
On 2016/06/29 20:05:59, fs wrote: lgtm
4 years, 5 months ago (2016-06-30 00:53:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105383002/1
4 years, 5 months ago (2016-06-30 07:56:58 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/210280) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 5 months ago (2016-06-30 08:04:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105383002/20001
4 years, 5 months ago (2016-06-30 08:14:20 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/248348)
4 years, 5 months ago (2016-06-30 09:09:58 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105383002/20001
4 years, 5 months ago (2016-06-30 10:24:51 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-30 12:28:41 UTC) #15
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 12:28:52 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 12:30:52 UTC) #18
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/8d8d4c8cd2fa6ed3357d7902bdf5adbeea471369
Cr-Commit-Position: refs/heads/master@{#403153}

Powered by Google App Engine
This is Rietveld 408576698