Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2105353002:
[gn] Switch linux64 debug and internal snapshot to gn (Closed)
|
Created:
4 years, 5 months ago by Michael Achenbach Modified:
4 years, 5 months ago CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[gn] Switch linux64 debug and internal snapshot to gn
BUG=chromium:474921
Committed: https://crrev.com/3cfc9f209ed0c173319659114859b7e848812fd7
Committed: https://crrev.com/38b31043ec59a44edde217ce89dcb912b5f76be5
Cr-Original-Commit-Position: refs/heads/master@{#37414}
Cr-Commit-Position: refs/heads/master@{#37425}
Patch Set 1 #Patch Set 2 : Bake in https://codereview.chromium.org/2109403002 #Patch Set 3 : Fix #
Messages
Total messages: 26 (13 generated)
Description was changed from ========== [gn] Switch linux64 debug to gn BUG= ========== to ========== [gn] Switch linux64 debug to gn BUG=chromium:474921 ==========
machenbach@chromium.org changed reviewers: + jochen@chromium.org, vogelheim@chromium.org
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [gn] Switch linux64 debug to gn BUG=chromium:474921 ========== to ========== [gn] Switch linux64 debug and internal snapshot to gn BUG=chromium:474921 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [gn] Switch linux64 debug and internal snapshot to gn BUG=chromium:474921 ========== to ========== [gn] Switch linux64 debug and internal snapshot to gn BUG=chromium:474921 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [gn] Switch linux64 debug and internal snapshot to gn BUG=chromium:474921 ========== to ========== [gn] Switch linux64 debug and internal snapshot to gn BUG=chromium:474921 Committed: https://crrev.com/3cfc9f209ed0c173319659114859b7e848812fd7 Cr-Commit-Position: refs/heads/master@{#37414} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/3cfc9f209ed0c173319659114859b7e848812fd7 Cr-Commit-Position: refs/heads/master@{#37414}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2109503007/ by machenbach@chromium.org. The reason for reverting is: Breaks....
Message was sent while issue was closed.
Description was changed from ========== [gn] Switch linux64 debug and internal snapshot to gn BUG=chromium:474921 Committed: https://crrev.com/3cfc9f209ed0c173319659114859b7e848812fd7 Cr-Commit-Position: refs/heads/master@{#37414} ========== to ========== [gn] Switch linux64 debug and internal snapshot to gn BUG=chromium:474921 Committed: https://crrev.com/3cfc9f209ed0c173319659114859b7e848812fd7 Cr-Commit-Position: refs/heads/master@{#37414} ==========
PTAL at patch3. Attempting reland with a fix. gn args needed outside of BUILD.gn, e.g. isolate.gni, need to be defined in v8.gni.
The CQ bit was checked by machenbach@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from vogelheim@chromium.org Link to the patchset: https://codereview.chromium.org/2105353002/#ps40001 (title: "Fix")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
Message was sent while issue was closed.
Description was changed from ========== [gn] Switch linux64 debug and internal snapshot to gn BUG=chromium:474921 Committed: https://crrev.com/3cfc9f209ed0c173319659114859b7e848812fd7 Cr-Commit-Position: refs/heads/master@{#37414} ========== to ========== [gn] Switch linux64 debug and internal snapshot to gn BUG=chromium:474921 Committed: https://crrev.com/3cfc9f209ed0c173319659114859b7e848812fd7 Cr-Commit-Position: refs/heads/master@{#37414} ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [gn] Switch linux64 debug and internal snapshot to gn BUG=chromium:474921 Committed: https://crrev.com/3cfc9f209ed0c173319659114859b7e848812fd7 Cr-Commit-Position: refs/heads/master@{#37414} ========== to ========== [gn] Switch linux64 debug and internal snapshot to gn BUG=chromium:474921 Committed: https://crrev.com/3cfc9f209ed0c173319659114859b7e848812fd7 Committed: https://crrev.com/38b31043ec59a44edde217ce89dcb912b5f76be5 Cr-Original-Commit-Position: refs/heads/master@{#37414} Cr-Commit-Position: refs/heads/master@{#37425} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/38b31043ec59a44edde217ce89dcb912b5f76be5 Cr-Commit-Position: refs/heads/master@{#37425} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
