Display outputs for "executable" targets in "gn desc".

Display outputs for "executable" targets in "gn desc".

BUG=None

Committed: https://crrev.com/4879ceddeebf12d55800f5bcb340c26e4f10fc10
Cr-Commit-Position: refs/heads/master@{#403654}

[sdefresne, 2016-06-29 13:23:46]

sdefresne@chromium.org changed reviewers:
+ brettw@chromium.org

[sdefresne, 2016-06-29 13:23:47]

Please take a look.

[brettw, 2016-06-29 23:12:10]

https://codereview.chromium.org/2105333002/diff/1/tools/gn/command_desc.cc
File tools/gn/command_desc.cc (right):

https://codereview.chromium.org/2105333002/diff/1/tools/gn/command_desc.cc#ne...
tools/gn/command_desc.cc:355: } else {
Currently the "outputs" section was actually the outputs variable. I don't see
any reason not to expand this, but we should document this specifically in the
"gn desc" help.

In this case, you should remove the condition below and always print the outputs
(excepting maybe source sets and groups). Then this else clause should be an
explicit "ACTION_FOREACH", and your new arm should actually be the else case
(handling all binary targets).

[sdefresne, 2016-07-01 13:12:40]

Please take another look.

https://codereview.chromium.org/2105333002/diff/1/tools/gn/command_desc.cc
File tools/gn/command_desc.cc (right):

https://codereview.chromium.org/2105333002/diff/1/tools/gn/command_desc.cc#ne...
tools/gn/command_desc.cc:355: } else {
On 2016/06/29 23:12:09, brettw (egregiously slow) wrote:
> Currently the "outputs" section was actually the outputs variable. I don't see
> any reason not to expand this, but we should document this specifically in the
> "gn desc" help.
> 
> In this case, you should remove the condition below and always print the
outputs
> (excepting maybe source sets and groups). Then this else clause should be an
> explicit "ACTION_FOREACH", and your new arm should actually be the else case
> (handling all binary targets).

Done.

[brettw, 2016-07-01 17:25:02]

lgtm

[sdefresne, 2016-07-04 08:32:38]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2016-07-04 08:32:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-04 09:20:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-04 09:21:40]

Description was changed from

==========
Display outputs for "executable" targets in "gn desc".

BUG=None
==========

to

==========
Display outputs for "executable" targets in "gn desc".

BUG=None

Committed: https://crrev.com/4879ceddeebf12d55800f5bcb340c26e4f10fc10
Cr-Commit-Position: refs/heads/master@{#403654}
==========

[commit-bot: I haz the power, 2016-07-04 09:21:41]

Patchset 2 (id:??) landed as
https://crrev.com/4879ceddeebf12d55800f5bcb340c26e4f10fc10
Cr-Commit-Position: refs/heads/master@{#403654}