test/cctest/compiler/value-helper.h - Issue 2105313002: [wasm] Detect unrepresentability in the float32-to-int32 conversion correctly on arm.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/compiler/value-helper.h

Issue 2105313002: [wasm] Detect unrepresentability in the float32-to-int32 conversion correctly on arm. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Define the bounds properly in variables. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/compiler/value-helper.h

diff --git a/test/cctest/compiler/value-helper.h b/test/cctest/compiler/value-helper.h

index 75d22b4d3532fc73304e27fbaf3144bf09033dbf..22982b8ac64d283edf9b3fc9c6426f4b6a330b18 100644

--- a/test/cctest/compiler/value-helper.h

+++ b/test/cctest/compiler/value-helper.h

@@ -82,6 +82,8 @@ class ValueHelper {

-4.66622e+11f,

-2.22581e+11f,

-1.45381e+10f,

+ -2147483649.0f, // INT32_MIN - 1

+ -2147483648.0f, // INT32_MIN

-1.3956e+09f,

-1.32951e+09f,

-1.30721e+09f,

@@ -151,6 +153,8 @@ class ValueHelper {

20309.0f,

797056.0f,

1.77219e+09f,

+ 2147483648.0f, // INT32_MAX + 1

+ 4294967296.0f, // UINT32_MAX + 1

1.51116e+11f,

4.18193e+13f,

3.59167e+16f,

« no previous file with comments | « test/cctest/compiler/test-run-machops.cc ('k') | test/cctest/wasm/test-run-wasm.cc » ('j') | no next file with comments »