Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Unified Diff: src/wasm/wasm-interpreter.cc

Issue 2105313002: [wasm] Detect unrepresentability in the float32-to-int32 conversion correctly on arm. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: address comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/wasm/wasm-interpreter.cc
diff --git a/src/wasm/wasm-interpreter.cc b/src/wasm/wasm-interpreter.cc
index dda4c1bb7dab0d7e0eeeb13dd19effbb0b0c056d..6c40c52ec118b1737da9402a4955bd64e80e04bd 100644
--- a/src/wasm/wasm-interpreter.cc
+++ b/src/wasm/wasm-interpreter.cc
@@ -515,7 +515,8 @@ static int32_t ExecuteI32SConvertF64(double a, TrapReason* trap) {
}
static uint32_t ExecuteI32UConvertF32(float a, TrapReason* trap) {
- if (a < (static_cast<float>(UINT32_MAX) + 1.0) && a > -1) {
+ if (a < (static_cast<float>(static_cast<uint64_t>(UINT32_MAX) + 1)) &&
+ a > -1) {
return static_cast<uint32_t>(a);
}
*trap = kTrapFloatUnrepresentable;

Powered by Google App Engine
This is Rietveld 408576698