[wasm] Disassemble wasm code from script

[wasm] Disassemble wasm code from script

This stores the wasm object and the function index in the script, and
adds functions to get the disassembled wasm code as well as the offset
table mapping from byte position to line and column in the disassembly
solely from the script.
This will be used to show "ui source code" in DevTools, and map raw
locations from the stack trace into this code view.

R=yangguo@chromium.org, ahaas@chromium.org, titzer@chromium.org
BUG=chromium:613110
patch from issue 2063013004 at patchset 80001 (http://crrev.com/2063013004#ps80001)

Committed: https://crrev.com/d249efd705cd851e8441ee3cc804669812ba1694
Cr-Commit-Position: refs/heads/master@{#37430}

[titzer, 2016-06-29 12:47:56]

On 2016/06/29 12:15:43, titzer wrote:

PTAL

[ahaas, 2016-06-29 14:27:27]

lgtm

https://codereview.chromium.org/2105303002/diff/1/src/debug/debug.js
File src/debug/debug.js (right):

https://codereview.chromium.org/2105303002/diff/1/src/debug/debug.js#newcode866
src/debug/debug.js:866: return null;
nit: wouldn't it be more javascripty to return undefined here instead of null?
;)

https://codereview.chromium.org/2105303002/diff/1/src/runtime/runtime-debug.cc
File src/runtime/runtime-debug.cc (right):

https://codereview.chromium.org/2105303002/diff/1/src/runtime/runtime-debug.c...
src/runtime/runtime-debug.cc:1790:
RUNTIME_FUNCTION(Runtime_GetWasmFunctionOffsetTable) {
I think this function should move to runtime-wasm.cc

https://codereview.chromium.org/2105303002/diff/1/src/runtime/runtime-debug.c...
src/runtime/runtime-debug.cc:1805:
RUNTIME_FUNCTION(Runtime_DisassembleWasmFunction) {
Same here.

[titzer, 2016-06-30 08:12:51]

https://codereview.chromium.org/2105303002/diff/1/src/debug/debug.js
File src/debug/debug.js (right):

https://codereview.chromium.org/2105303002/diff/1/src/debug/debug.js#newcode866
src/debug/debug.js:866: return null;
On 2016/06/29 14:27:27, ahaas wrote:
> nit: wouldn't it be more javascripty to return undefined here instead of null?
> ;)

Done.

https://codereview.chromium.org/2105303002/diff/1/src/runtime/runtime-debug.cc
File src/runtime/runtime-debug.cc (right):

https://codereview.chromium.org/2105303002/diff/1/src/runtime/runtime-debug.c...
src/runtime/runtime-debug.cc:1790:
RUNTIME_FUNCTION(Runtime_GetWasmFunctionOffsetTable) {
On 2016/06/29 14:27:27, ahaas wrote:
> I think this function should move to runtime-wasm.cc

Since these primarily have to do with debugging (as opposed to normal operation
of WASM), I'm OK keeping them here.

[titzer, 2016-06-30 09:25:37]

The CQ bit was checked by titzer@chromium.org

[titzer, 2016-06-30 09:25:38]

The patchset sent to the CQ was uploaded after l-g-t-m from ahaas@chromium.org
Link to the patchset: https://codereview.chromium.org/2105303002/#ps40001
(title: "[wasm] Disassemble wasm code from script")

[commit-bot: I haz the power, 2016-06-30 09:25:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 09:29:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-30 09:29:51]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/18519)

[Yang, 2016-06-30 09:50:41]

On 2016/06/30 09:29:51, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   v8_presubmit on master.tryserver.v8 (JOB_FAILED,
> http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/18519)

lgtm (rubberstamp)

[titzer, 2016-06-30 09:52:38]

The CQ bit was checked by titzer@chromium.org

[commit-bot: I haz the power, 2016-06-30 09:52:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 09:54:46]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-30 09:57:17]

Description was changed from

==========
[wasm] Disassemble wasm code from script

This stores the wasm object and the function index in the script, and
adds functions to get the disassembled wasm code as well as the offset
table mapping from byte position to line and column in the disassembly
solely from the script.
This will be used to show "ui source code" in DevTools, and map raw
locations from the stack trace into this code view.

R=yangguo@chromium.org, ahaas@chromium.org, titzer@chromium.org
BUG=chromium:613110

patch from issue 2063013004 at patchset 80001
(http://crrev.com/2063013004#ps80001)
==========

to

==========
[wasm] Disassemble wasm code from script

This stores the wasm object and the function index in the script, and
adds functions to get the disassembled wasm code as well as the offset
table mapping from byte position to line and column in the disassembly
solely from the script.
This will be used to show "ui source code" in DevTools, and map raw
locations from the stack trace into this code view.

R=yangguo@chromium.org, ahaas@chromium.org, titzer@chromium.org
BUG=chromium:613110

patch from issue 2063013004 at patchset 80001
(http://crrev.com/2063013004#ps80001)

Committed: https://crrev.com/d249efd705cd851e8441ee3cc804669812ba1694
Cr-Commit-Position: refs/heads/master@{#37430}
==========

[commit-bot: I haz the power, 2016-06-30 09:57:18]

Patchset 3 (id:??) landed as
https://crrev.com/d249efd705cd851e8441ee3cc804669812ba1694
Cr-Commit-Position: refs/heads/master@{#37430}