Add .sha1 files corresponding to media files uploaded to chromium-wpr bucket.

Add .sha1 files corresponding to media files uploaded to chromium-wpr bucket.

BUG=261318
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214924

[shadi, 2013-07-29 21:25:47]

These are the sha1 files for media files I uploaded to chromium-wpr bucket. 

PTAL.

[dtu, 2013-07-30 00:07:17]

Can they go in a new folder page_sets/data? It's a little easier to have them in
a separate folder from any checked-in files. (e.g. the .gitignore only needs to
whitelist .sha1 files)

[shadi, 2013-07-30 00:18:11]

On 2013/07/30 00:07:17, Dave Tu wrote:
> Can they go in a new folder page_sets/data? It's a little easier to have them
in
> a separate folder from any checked-in files. (e.g. the .gitignore only needs
to
> whitelist .sha1 files)
I guess I was thinking along the lines that html files and media files are
easier to have in one folder. 
If I move the files to data, the test html will point to data by
'../../data/<file>'?

[dtu, 2013-07-30 00:42:14]

On 2013/07/30 00:18:11, shadi wrote:
> On 2013/07/30 00:07:17, Dave Tu wrote:
> > Can they go in a new folder page_sets/data? It's a little easier to have
them
> in
> > a separate folder from any checked-in files. (e.g. the .gitignore only needs
> to
> > whitelist .sha1 files)
> I guess I was thinking along the lines that html files and media files are
> easier to have in one folder. 
> If I move the files to data, the test html will point to data by
> '../../data/<file>'?

Just upload the html file too :)
I think the page set data html and js files are rarely modified, so it's okay to
lose the source code searchability and diff. Let me know if that seems wrong.

[shadi, 2013-07-30 16:28:21]

On 2013/07/30 00:42:14, Dave Tu wrote:
> On 2013/07/30 00:18:11, shadi wrote:
> > On 2013/07/30 00:07:17, Dave Tu wrote:
> > > Can they go in a new folder page_sets/data? It's a little easier to have
> them
> > in
> > > a separate folder from any checked-in files. (e.g. the .gitignore only
needs
> > to
> > > whitelist .sha1 files)
> > I guess I was thinking along the lines that html files and media files are
> > easier to have in one folder. 
> > If I move the files to data, the test html will point to data by
> > '../../data/<file>'?
> 
> Just upload the html file too :)
> I think the page set data html and js files are rarely modified, so it's okay
to
> lose the source code searchability and diff. Let me know if that seems wrong.

Yeah, it does not seem right to upload html and JS code, at least not for now
while we are in process of writing page sets and finalizing them. Plus, I
thought that by default when running the tests, the http server root is the
page_set/test_case/ folder. Moving the html to data/ will break that.

I guess, I can move the files to data and update the tests to point to
../../data/ for now. We can add a web server proxy http://localhost:port/data/
later maybe?

[dtu, 2013-07-31 01:30:12]

On 2013/07/30 16:28:21, shadi wrote:
> On 2013/07/30 00:42:14, Dave Tu wrote:
> > On 2013/07/30 00:18:11, shadi wrote:
> > > On 2013/07/30 00:07:17, Dave Tu wrote:
> > > > Can they go in a new folder page_sets/data? It's a little easier to have
> > them
> > > in
> > > > a separate folder from any checked-in files. (e.g. the .gitignore only
> needs
> > > to
> > > > whitelist .sha1 files)
> > > I guess I was thinking along the lines that html files and media files are
> > > easier to have in one folder. 
> > > If I move the files to data, the test html will point to data by
> > > '../../data/<file>'?
> > 
> > Just upload the html file too :)
> > I think the page set data html and js files are rarely modified, so it's
okay
> to
> > lose the source code searchability and diff. Let me know if that seems
wrong.
> 
> Yeah, it does not seem right to upload html and JS code, at least not for now
> while we are in process of writing page sets and finalizing them. Plus, I
> thought that by default when running the tests, the http server root is the
> page_set/test_case/ folder. Moving the html to data/ will break that.
> 
> I guess, I can move the files to data and update the tests to point to
> ../../data/ for now. We can add a web server proxy http://localhost:port/data/
> later maybe?

Okay, Tony and I decided that we can keep the existing directory structure,
without a data/ folder. We'll specifically whitelist/blacklist binaries to go in
Cloud Storage, and text files to be checked in. Sorry for the churn.

(Side note, AFAIK, the default HTTP server root is just to serve the directory
in the page's URL.)

[anandc, 2013-07-31 22:27:58]

On 2013/07/31 01:30:12, Dave Tu wrote:
> On 2013/07/30 16:28:21, shadi wrote:
> > On 2013/07/30 00:42:14, Dave Tu wrote:
> > > On 2013/07/30 00:18:11, shadi wrote:
> > > > On 2013/07/30 00:07:17, Dave Tu wrote:
> > > > > Can they go in a new folder page_sets/data? It's a little easier to
have
> > > them
> > > > in
> > > > > a separate folder from any checked-in files. (e.g. the .gitignore only
> > needs
> > > > to
> > > > > whitelist .sha1 files)
> > > > I guess I was thinking along the lines that html files and media files
are
> > > > easier to have in one folder. 
> > > > If I move the files to data, the test html will point to data by
> > > > '../../data/<file>'?
> > > 
> > > Just upload the html file too :)
> > > I think the page set data html and js files are rarely modified, so it's
> okay
> > to
> > > lose the source code searchability and diff. Let me know if that seems
> wrong.
> > 
> > Yeah, it does not seem right to upload html and JS code, at least not for
now
> > while we are in process of writing page sets and finalizing them. Plus, I
> > thought that by default when running the tests, the http server root is the
> > page_set/test_case/ folder. Moving the html to data/ will break that.
> > 
> > I guess, I can move the files to data and update the tests to point to
> > ../../data/ for now. We can add a web server proxy
http://localhost:port/data/
> > later maybe?
> 
> Okay, Tony and I decided that we can keep the existing directory structure,
> without a data/ folder. We'll specifically whitelist/blacklist binaries to go
in
> Cloud Storage, and text files to be checked in. Sorry for the churn.
> 
> (Side note, AFAIK, the default HTTP server root is just to serve the directory
> in the page's URL.)

So, does this lgty then? Thanks.

[dtu, 2013-07-31 22:30:05]

lgtm

[commit-bot: I haz the power, 2013-07-31 22:37:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shadi@chromium.org/21053008/1

[commit-bot: I haz the power, 2013-08-01 00:38:14]

Retried try job too often on mac_rel for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-08-01 01:56:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shadi@chromium.org/21053008/1

[commit-bot: I haz the power, 2013-08-01 02:32:05]

Change committed as 214924