Issue 21053002: Fix d8 build error when V8_SHARED is unset on Linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21053002: Fix d8 build error when V8_SHARED is unset on Linux. (Closed)

Created:
7 years, 4 months ago by Benedikt Meurer

Modified:
7 years, 4 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix d8 build error when V8_SHARED is unset on Linux. TBR=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15927

Patch Set 1 #

Total comments: 1

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/d8.cc	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Benedikt Meurer

Committed patchset #1 manually as r15927 (presubmit successful).

7 years, 4 months ago (2013-07-29 10:23:14 UTC) #1

Sven Panne

7 years, 4 months ago (2013-07-29 11:05:39 UTC) #2

Message was sent while issue was closed.

https://codereview.chromium.org/21053002/diff/1/src/d8.cc
File src/d8.cc (right):

https://codereview.chromium.org/21053002/diff/1/src/d8.cc#newcode71
src/d8.cc:71: #if !defined(_WIN32) && !defined(_WIN64)
I don't think this is actually correct for compilation under cygwin with
-mno-cygwin, but we probably have several other buggy places like this. I'll try
to find my cheat sheet with preprocessor defines...

Expand Messages | Collapse Messages