third_party/WebKit/Source/core/loader/ImageLoader.h - Issue 2105283002: <image>'s src URL is resolved incorrectly when <base> element dynamically added

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/ImageLoader.h

Issue 2105283002: <image>'s src URL is resolved incorrectly when <base> element dynamically added (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: <image>'s src URL is resolved incorrectly when <base> element dynamically added. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/loader/image-loader-base.html ('K') | « third_party/WebKit/LayoutTests/loader/image-loader-base-expected.txt ('k') | third_party/WebKit/Source/core/loader/ImageLoader.cpp » ('j') | third_party/WebKit/Source/core/loader/ImageLoader.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/loader/ImageLoader.h

diff --git a/third_party/WebKit/Source/core/loader/ImageLoader.h b/third_party/WebKit/Source/core/loader/ImageLoader.h

index 5ac085d4687d07475824ad8d4274589ee7617c40..03f25bf99d263211c094bdca51b5ccbc55739c6d 100644

--- a/third_party/WebKit/Source/core/loader/ImageLoader.h

+++ b/third_party/WebKit/Source/core/loader/ImageLoader.h

@@ -115,7 +115,7 @@ private:

class Task;

// Called from the task or from updateFromElement to initiate the load.

- void doUpdateFromElement(BypassMainWorldBehavior, UpdateFromElementBehavior, ReferrerPolicy = ReferrerPolicyDefault);

+ void doUpdateFromElement(BypassMainWorldBehavior, UpdateFromElementBehavior, const KURL&, ReferrerPolicy = ReferrerPolicyDefault);

virtual void dispatchLoadEvent() = 0;

virtual void noImageResourceToLoad() { }