third_party/WebKit/LayoutTests/loader/image-loader-base.html - Issue 2105283002: <image>'s src URL is resolved incorrectly when <base> element dynamically added

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/loader/image-loader-base.html

Issue 2105283002: <image>'s src URL is resolved incorrectly when <base> element dynamically added (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: <image>'s src URL is resolved incorrectly when <base> element dynamically added. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <title>base element test </title>

	5 <script src="../resources/testharness.js"></script>

	6 <script src="../resources/testharnessreport.js"></script>

	7 <script>

	8 function failed() {

	9 test (function() {
	Yoav Weiss 2016/07/12 08:39:48 You want to run an async test which is initiated g You want to run an async test which is initiated globally. See LayoutTests/http/tests/preload for examples.
	10 assert_unreached(" This is onerror() of image. ");

	11 }, "Image Loading");

	12

	13 }

	14 function succeeded() {

	15 test (function() {

	16 assert_true(true, "reference image is loadec successfully");
	Yoav Weiss 2016/07/12 08:39:48 s/loadec/loaded/ s/loadec/loaded/
	17 }, "Image Loading.");

	18 }

	19

	20 </script>

	21 </head>

	22 <body>

	23 Test for bugs.chromium.org #569760: <br/>

	24 <img id="img1"><br/>

	25 Reference<br/>

	26 <img id="ref" onerror="failed()" onload="succeeded()">

	27 <script>

	28 var ref = document.getElementById('ref');

	29 ref.src = 'resources/image1.png';
	Yoav Weiss 2016/07/12 08:39:48 You're testing the reference image rather than the You're testing the reference image rather than the one you actually want to test. It might be better to get rid of the reference image here altogether
	30

	31 var base = document.createElement("base");

	32 base.setAttribute("href", "resources/");

	33 document.head.appendChild(base);

	34 var img1 = document.getElementById('img1');

	35 img1.src = 'image1.png';

	36 </script>

	37 </body>

	38 </html>

OLD	NEW

« no previous file with comments | « AUTHORS ('k') | third_party/WebKit/Source/core/loader/ImageLoader.h » ('j') | no next file with comments »