third_party/WebKit/LayoutTests/loader/image-loader-base.html - Issue 2105283002: <image>'s src URL is resolved incorrectly when <base> element dynamically added

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/loader/image-loader-base.html

Issue 2105283002: <image>'s src URL is resolved incorrectly when <base> element dynamically added (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: <image>'s src URL is resolved incorrectly when <base> element dynamically added. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <title>base element test </title>

	5 <script>

	6 if (window.testRunner)

	7 testRunner.dumpAsText();

	8

	9 function runTest() {

	10 var image = document.getElementsByTagName('img')[1];
	Yoav Weiss 2016/07/04 07:18:14 I'm assuming you're using natural{Width, Height} a I'm assuming you're using natural{Width, Height} as a proxy to the fact that the image is broken? Could you use onerror instead, which is more direct? Could you use testharness based tests, instead of an expected.txt one? (Tutorial at http://testthewebforward.org/docs/testharness-tutorial.html and you can grep "testharness" for examples layout tests)
	11 if (image.naturalHeight != 0 \|\| image.naturalWidth != 0)

	12 document.write('PASS');

	13 else

	14 document.write('FAIL: <base> is added after reference image is set. ');

	15 }

	16 </script>

	17 </head>

	18 <body onload="runTest()">

	19 Test for bugs.chromium.org #569760: <br/>

	20 <div id="">
	Yoav Weiss 2016/07/04 07:18:14 Why a div here? Why a div here?
	21 <img id="img1" src=""><br>
	Yoav Weiss 2016/07/04 07:18:14 Is the empty "src" part of the test? If not, can y Is the empty "src" part of the test? If not, can you eliminate it?
	22 Reference<br>
	Yoav Weiss 2016/07/04 07:18:14 Why is this indented? Why is this indented?
	23 <img id="ref" src=" ">

	24 </div>

	25 <script>

	26 document.getElementById('ref').src = 'resources/image1.png';
	Yoav Weiss 2016/07/04 07:18:14 Inconsistent indentation. 4 spaces as indentation Inconsistent indentation. 4 spaces as indentation is the common style in Blink.
	27

	28 var base = document.createElement("base");

	29 base.setAttribute("href", "resources/");

	30 document.head.appendChild(base);

	31 document.getElementById('img1').src = 'image1.png';

	32 </script>

	33 </body>

	34 </html>

OLD	NEW

« no previous file with comments | « AUTHORS ('k') | third_party/WebKit/LayoutTests/loader/image-loader-base-expected.txt » ('j') | third_party/WebKit/Source/core/loader/ImageLoader.cpp » ('J')