Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: third_party/WebKit/Source/core/paint/ObjectPaintProperties.h

Issue 2105273004: GeometryMapper: Support computing visual rects in spaces that are not direct ancestors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: none Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/paint/ObjectPaintProperties.h
diff --git a/third_party/WebKit/Source/core/paint/ObjectPaintProperties.h b/third_party/WebKit/Source/core/paint/ObjectPaintProperties.h
index 3ebd68e98e8d6a9c468a83ba08496d661afbef21..db6e7070340f7d58527568e16531d5182ebe5391 100644
--- a/third_party/WebKit/Source/core/paint/ObjectPaintProperties.h
+++ b/third_party/WebKit/Source/core/paint/ObjectPaintProperties.h
@@ -5,10 +5,12 @@
#ifndef ObjectPaintProperties_h
#define ObjectPaintProperties_h
+#include "core/CoreExport.h"
#include "platform/geometry/LayoutPoint.h"
#include "platform/graphics/paint/ClipPaintPropertyNode.h"
#include "platform/graphics/paint/EffectPaintPropertyNode.h"
#include "platform/graphics/paint/PaintChunkProperties.h"
+#include "platform/graphics/paint/PropertyTreeState.h"
#include "platform/graphics/paint/TransformPaintPropertyNode.h"
#include "wtf/PassRefPtr.h"
#include "wtf/PtrUtil.h"
@@ -22,7 +24,7 @@ namespace blink {
// 1. The set of property nodes created locally by this LayoutObject.
// 2. [Optional] A suite of property nodes (PaintChunkProperties) and paint offset
// that can be used to paint the border box of this LayoutObject.
-class ObjectPaintProperties {
+class CORE_EXPORT ObjectPaintProperties {
WTF_MAKE_NONCOPYABLE(ObjectPaintProperties);
USING_FAST_MALLOC(ObjectPaintProperties);
public:
@@ -33,7 +35,7 @@ public:
return wrapUnique(new ObjectPaintProperties());
}
- // The hierarchy of transform subtree created by a LayoutObject.
+ // The hierarchy of the transform subtree created by a LayoutObject is as follows:
// [ paintOffsetTranslation ] Normally paint offset is accumulated without creating a node
// | until we see, for example, transform or position:fixed.
// +---[ transform ] The space created by CSS transform.
@@ -55,6 +57,10 @@ public:
EffectPaintPropertyNode* effect() const { return m_effect.get(); }
+ // The hierarchy of the clip subtree created by a LayoutObject is as follows:
+ // [ css clip ]
+ // |
+ // +--- [ overflow clip ]
ClipPaintPropertyNode* cssClip() const { return m_cssClip.get(); }
ClipPaintPropertyNode* cssClipFixedPosition() const { return m_cssClipFixedPosition.get(); }
ClipPaintPropertyNode* overflowClip() const { return m_overflowClip.get(); }
@@ -68,9 +74,7 @@ public:
// at the right painting step.
struct LocalBorderBoxProperties {
LayoutPoint paintOffset;
- RefPtr<TransformPaintPropertyNode> transform;
- RefPtr<ClipPaintPropertyNode> clip;
- RefPtr<EffectPaintPropertyNode> effect;
+ PropertyTreeState propertyTreeState;
};
LocalBorderBoxProperties* localBorderBoxProperties() const { return m_localBorderBoxProperties.get(); }
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698