GeometryMapper: Support computing visual rects in spaces that are not direct ancestors.

third_party/WebKit/Source/platform/graphics/paint/TransformPaintPropertyNode.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef TransformPaintPropertyNode_h
 #define TransformPaintPropertyNode_h
 
 #include "platform/PlatformExport.h"
 #include "platform/geometry/FloatPoint3D.h"
 #include "platform/transforms/TransformationMatrix.h"
@@ skipping 13 matching lines @@
     static PassRefPtr<TransformPaintPropertyNode> create(const TransformationMatrix& matrix, const FloatPoint3D& origin, PassRefPtr<TransformPaintPropertyNode> parent = nullptr)
     {
         return adoptRef(new TransformPaintPropertyNode(matrix, origin, parent));
     }
 
     const TransformationMatrix& matrix() const { return m_matrix; }
     const FloatPoint3D& origin() const { return m_origin; }
 
     // Parent transform that this transform is relative to, or nullptr if this
     // is the root transform.
-    const TransformPaintPropertyNode* parent() const { return m_parent.get(); }
+    TransformPaintPropertyNode* parent() const { return m_parent.get(); }
+
+    // Do not use this method if possible, use parent() instead, to preserve const-ness.
+    PassRefPtr<TransformPaintPropertyNode> parentRef() const { return m_parent; }

[chrishtr, 2016/06/30 16:49:55]

Needed so that we can store a refptr to a parent in a PropertyTreeState, which
happens when passing to the
least-common-ancestor.

[pdr., 2016/06/30 21:21:50]

This doesn't appear to be used in this patch.

[chrishtr, 2016/07/01 17:52:24]

Removed. The test was crashing due to refptr counting, then I added this to fix
it, but it's now not crashing any more. I can easily re-add later if needed.

 
 private:
+
     TransformPaintPropertyNode(const TransformationMatrix& matrix, const FloatPoint3D& origin, PassRefPtr<TransformPaintPropertyNode> parent)
         : m_matrix(matrix), m_origin(origin), m_parent(parent) { }
 
     const TransformationMatrix m_matrix;
     const FloatPoint3D m_origin;
     RefPtr<TransformPaintPropertyNode> m_parent;
 };
 
 // Redeclared here to avoid ODR issues.
 // See platform/testing/PaintPrinters.h.
 void PrintTo(const TransformPaintPropertyNode&, std::ostream*);
 
 } // namespace blink
 
 #endif // TransformPaintPropertyNode_h