GeometryMapper: Support computing visual rects in spaces that are not direct ancestors.

third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/layout/LayoutTestHelper.h"
 #include "core/layout/LayoutTreeAsText.h"
 #include "core/layout/LayoutView.h"
 #include "core/paint/ObjectPaintProperties.h"
+#include "platform/graphics/paint/GeometryMapper.h"
 #include "platform/graphics/paint/TransformPaintPropertyNode.h"
 #include "platform/testing/UnitTestHelpers.h"
 #include "platform/text/TextStream.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "wtf/HashMap.h"
 #include "wtf/Vector.h"
 
 namespace blink {
 
 class PaintPropertyTreeBuilderTest : public RenderingTest {
@@ skipping 25 matching lines @@
     {
         RenderingTest::TearDown();
 
         Settings::setMockScrollbarsEnabled(false);
         RuntimeEnabledFeatures::setSlimmingPaintV2Enabled(m_originalSlimmingPaintV2Enabled);
     }
 
     bool m_originalSlimmingPaintV2Enabled;
 };
 
+#define CHECK_VISUAL_RECT(sourceLayoutObject, ancestorLayoutObject) \
+do { \
+    GeometryMapper geometryMapper; \
+    LayoutRect source(sourceLayoutObject->localOverflowRectForPaintInvalidation()); \
+    source.moveBy(sourceLayoutObject->objectPaintProperties()->localBorderBoxProperties()->paintOffset); \
+    bool success = false; \
+    FloatRect actual = geometryMapper.mapToVisualRectInDestinationSpace( \
+        FloatRect(source), \
+        sourceLayoutObject->objectPaintProperties()->localBorderBoxProperties()->propertyTreeState, \
+        ancestorLayoutObject->objectPaintProperties()->localBorderBoxProperties()->propertyTreeState, &success); \
+    EXPECT_TRUE(success); \
+\
+    LayoutRect expected = sourceLayoutObject->localOverflowRectForPaintInvalidation(); \
+    sourceLayoutObject->mapToVisualRectInAncestorSpace(ancestorLayoutObject, expected); \
+    EXPECT_EQ(expected, LayoutRect(actual)); \
+} while (0);
+
 TEST_F(PaintPropertyTreeBuilderTest, FixedPosition)
 {
     loadTestData("fixed-position.html");
 
     FrameView* frameView = document().view();
 
     // target1 is a fixed-position element inside an absolute-position scrolling element.
     // It should be attached under the viewport to skip scrolling and offset of the parent.
     Element* target1 = document().getElementById("target1");
     ObjectPaintProperties* target1Properties = target1->layoutObject()->objectPaintProperties();
     EXPECT_EQ(TransformationMatrix().translate(200, 150), target1Properties->paintOffsetTranslation()->matrix());
     EXPECT_EQ(frameView->preTranslation(), target1Properties->paintOffsetTranslation()->parent());
     EXPECT_EQ(target1Properties->paintOffsetTranslation(), target1Properties->overflowClip()->localTransformSpace());
     EXPECT_EQ(FloatRoundedRect(0, 0, 100, 100), target1Properties->overflowClip()->clipRect());
     // Likewise, it inherits clip from the viewport, skipping overflow clip of the scroller.
     EXPECT_EQ(frameView->contentClip(), target1Properties->overflowClip()->parent());
 
     // target2 is a fixed-position element inside a transformed scrolling element.
     // It should be attached under the scrolled box of the transformed element.
     Element* target2 = document().getElementById("target2");
     ObjectPaintProperties* target2Properties = target2->layoutObject()->objectPaintProperties();
     Element* scroller = document().getElementById("scroller");
     ObjectPaintProperties* scrollerProperties = scroller->layoutObject()->objectPaintProperties();
     EXPECT_EQ(TransformationMatrix().translate(200, 150), target2Properties->paintOffsetTranslation()->matrix());
     EXPECT_EQ(scrollerProperties->scrollTranslation(), target2Properties->paintOffsetTranslation()->parent());
     EXPECT_EQ(target2Properties->paintOffsetTranslation(), target2Properties->overflowClip()->localTransformSpace());
     EXPECT_EQ(FloatRoundedRect(0, 0, 100, 100), target2Properties->overflowClip()->clipRect());
     EXPECT_EQ(scrollerProperties->overflowClip(), target2Properties->overflowClip()->parent());
+
+    CHECK_VISUAL_RECT(target1->layoutObject(), frameView->layoutView());

[chrishtr, 2016/06/30 16:49:55]

I plan to fix target2 in the next CL.

 }
 
 TEST_F(PaintPropertyTreeBuilderTest, PositionAndScroll)
 {
     loadTestData("position-and-scroll.html");
 
     Element* scroller = document().getElementById("scroller");
     scroller->scrollTo(0, 100);
     FrameView* frameView = document().view();
     frameView->updateAllLifecyclePhases();
@@ skipping 634 matching lines @@
         "  <div id='child' style='position:relative;'></div>"
         "  <div style='height:10000px;'></div>"
         "</div>"
     );
 
     LayoutObject& scroller = *document().getElementById("scroller")->layoutObject();
     ObjectPaintProperties* scrollerProperties = scroller.objectPaintProperties();
     LayoutObject& child = *document().getElementById("child")->layoutObject();
     ObjectPaintProperties* childProperties = child.objectPaintProperties();
 
-    EXPECT_EQ(scrollerProperties->overflowClip(), childProperties->localBorderBoxProperties()->clip);
-    EXPECT_EQ(scrollerProperties->scrollTranslation(), childProperties->localBorderBoxProperties()->transform);
-    EXPECT_NE(nullptr, childProperties->localBorderBoxProperties()->effect);
+    EXPECT_EQ(scrollerProperties->overflowClip(), childProperties->localBorderBoxProperties()->propertyTreeState.clip);
+    EXPECT_EQ(scrollerProperties->scrollTranslation(), childProperties->localBorderBoxProperties()->propertyTreeState.transform);
+    EXPECT_NE(nullptr, childProperties->localBorderBoxProperties()->propertyTreeState.effect);
 }
 
 TEST_F(PaintPropertyTreeBuilderTest, TreeContextUnclipFromParentStackingContext)
 {
     // This test verifies the tree builder correctly computes and records the property tree context
     // for a (pseudo) stacking context that has a scrolling painting ancestor that is not its
     // containing block (thus should not be scrolled by it).
 
     setBodyInnerHTML(
         "<style>body { margin: 0; }</style>"
         "<div id='scroller' style='overflow:scroll; opacity:0.5;'>"
         "  <div id='child' style='position:absolute; left:0; top:0;'></div>"
         "  <div style='height:10000px;'></div>"
         "</div>"
     );
 
     FrameView* frameView = document().view();
     LayoutObject& scroller = *document().getElementById("scroller")->layoutObject();
     ObjectPaintProperties* scrollerProperties = scroller.objectPaintProperties();
     LayoutObject& child = *document().getElementById("child")->layoutObject();
     ObjectPaintProperties* childProperties = child.objectPaintProperties();
 
-    EXPECT_EQ(frameView->contentClip(), childProperties->localBorderBoxProperties()->clip);
-    EXPECT_EQ(frameView->scrollTranslation(), childProperties->localBorderBoxProperties()->transform);
-    EXPECT_EQ(scrollerProperties->effect(), childProperties->localBorderBoxProperties()->effect);
+    EXPECT_EQ(frameView->contentClip(), childProperties->localBorderBoxProperties()->propertyTreeState.clip);
+    EXPECT_EQ(frameView->scrollTranslation(), childProperties->localBorderBoxProperties()->propertyTreeState.transform);
+    EXPECT_EQ(scrollerProperties->effect(), childProperties->localBorderBoxProperties()->propertyTreeState.effect);
 }
 
 TEST_F(PaintPropertyTreeBuilderTest, TableCellLayoutLocation)
 {
     // This test verifies that the border box space of a table cell is being correctly computed.
     // Table cells have weird location adjustment in our layout/paint implementation.
     setBodyInnerHTML(
         "<style>"
         "  body {"
         "    margin: 0;"
@@ skipping 19 matching lines @@
         "  <tr><td></td><td></td></tr>"
         "  <tr><td></td><td><div id='target'></div></td></tr>"
         "</table>"
     );
 
     FrameView* frameView = document().view();
     LayoutObject& target = *document().getElementById("target")->layoutObject();
     ObjectPaintProperties* targetProperties = target.objectPaintProperties();
 
     EXPECT_EQ(LayoutPoint(170, 170), targetProperties->localBorderBoxProperties()->paintOffset);
-    EXPECT_EQ(frameView->scrollTranslation(), targetProperties->localBorderBoxProperties()->transform);
+    EXPECT_EQ(frameView->scrollTranslation(), targetProperties->localBorderBoxProperties()->propertyTreeState.transform);
 }
 
 TEST_F(PaintPropertyTreeBuilderTest, CSSClipFixedPositionDescendant)
 {
     // This test verifies that clip tree hierarchy being generated correctly for the hard case
     // such that a fixed position element getting clipped by an absolute position CSS clip.
     setBodyInnerHTML(
         "<style>"
         "  #clip {"
         "    position: absolute;"
@@ skipping 18 matching lines @@
     FrameView* frameView = document().view();
 
     LayoutObject& clip = *document().getElementById("clip")->layoutObject();
     ObjectPaintProperties* clipProperties = clip.objectPaintProperties();
     EXPECT_EQ(frameView->contentClip(), clipProperties->cssClip()->parent());
     EXPECT_EQ(frameView->scrollTranslation(), clipProperties->cssClip()->localTransformSpace());
     EXPECT_EQ(FloatRoundedRect(FloatRect(absoluteClipRect)), clipProperties->cssClip()->clipRect());
 
     LayoutObject& fixed = *document().getElementById("fixed")->layoutObject();
     ObjectPaintProperties* fixedProperties = fixed.objectPaintProperties();
-    EXPECT_EQ(clipProperties->cssClip(), fixedProperties->localBorderBoxProperties()->clip);
-    EXPECT_EQ(frameView->preTranslation(), fixedProperties->localBorderBoxProperties()->transform->parent());
-    EXPECT_EQ(TransformationMatrix().translate(654, 321), fixedProperties->localBorderBoxProperties()->transform->matrix());
+    EXPECT_EQ(clipProperties->cssClip(), fixedProperties->localBorderBoxProperties()->propertyTreeState.clip);
+    EXPECT_EQ(frameView->preTranslation(), fixedProperties->localBorderBoxProperties()->propertyTreeState.transform->parent());
+    EXPECT_EQ(TransformationMatrix().translate(654, 321), fixedProperties->localBorderBoxProperties()->propertyTreeState.transform->matrix());
     EXPECT_EQ(LayoutPoint(), fixedProperties->localBorderBoxProperties()->paintOffset);
 }
 
 TEST_F(PaintPropertyTreeBuilderTest, CSSClipFixedPositionDescendantNonShared)
 {
     // This test is similar to CSSClipFixedPositionDescendant above, except that
     // now we have a parent overflow clip that should be escaped by the fixed descendant.
     setBodyInnerHTML(
         "<style>"
         "  body {"
@@ skipping 36 matching lines @@
     ObjectPaintProperties* clipProperties = clip.objectPaintProperties();
     EXPECT_EQ(overflowProperties->overflowClip(), clipProperties->cssClip()->parent());
     EXPECT_EQ(overflowProperties->scrollTranslation(), clipProperties->cssClip()->localTransformSpace());
     EXPECT_EQ(FloatRoundedRect(FloatRect(absoluteClipRect)), clipProperties->cssClip()->clipRect());
     EXPECT_EQ(frameView->contentClip(), clipProperties->cssClipFixedPosition()->parent());
     EXPECT_EQ(overflowProperties->scrollTranslation(), clipProperties->cssClipFixedPosition()->localTransformSpace());
     EXPECT_EQ(FloatRoundedRect(FloatRect(absoluteClipRect)), clipProperties->cssClipFixedPosition()->clipRect());
 
     LayoutObject& fixed = *document().getElementById("fixed")->layoutObject();
     ObjectPaintProperties* fixedProperties = fixed.objectPaintProperties();
-    EXPECT_EQ(clipProperties->cssClipFixedPosition(), fixedProperties->localBorderBoxProperties()->clip);
-    EXPECT_EQ(frameView->preTranslation(), fixedProperties->localBorderBoxProperties()->transform->parent());
-    EXPECT_EQ(TransformationMatrix().translate(654, 321), fixedProperties->localBorderBoxProperties()->transform->matrix());
+    EXPECT_EQ(clipProperties->cssClipFixedPosition(), fixedProperties->localBorderBoxProperties()->propertyTreeState.clip);
+    EXPECT_EQ(frameView->preTranslation(), fixedProperties->localBorderBoxProperties()->propertyTreeState.transform->parent());
+    EXPECT_EQ(TransformationMatrix().translate(654, 321), fixedProperties->localBorderBoxProperties()->propertyTreeState.transform->matrix());
     EXPECT_EQ(LayoutPoint(), fixedProperties->localBorderBoxProperties()->paintOffset);
 }
 
 TEST_F(PaintPropertyTreeBuilderTest, ColumnSpannerUnderRelativePositioned)
 {
     setBodyInnerHTML(
         "<div style='columns: 3; position: absolute; top: 44px; left: 55px;'>"
         "  <div style='position: relative; top: 100px; left: 100px'>"
         "    <div id='spanner' style='column-span: all; opacity: 0.5; width: 100px; height: 100px;'></div>"
         "  </div>"
         "</div>"
     );
 
     LayoutObject& spanner = *getLayoutObjectByElementId("spanner");
     EXPECT_EQ(LayoutPoint(55, 44), spanner.objectPaintProperties()->localBorderBoxProperties()->paintOffset);
 }
 
 } // namespace blink