Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2105263003: Roll buildtools to fix checkdeps on Windows. (Closed)

Created:
4 years, 5 months ago by jam
Modified:
4 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll buildtools to fix checkdeps on Windows. BUG=624445 Committed: https://crrev.com/7fdab8abba2415d4bd126d8a66da107b2485d2c9 Cr-Commit-Position: refs/heads/master@{#403242}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
jam
4 years, 5 months ago (2016-06-29 22:54:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105263003/1
4 years, 5 months ago (2016-06-29 22:56:12 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 5 months ago (2016-06-29 22:56:14 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105263003/1
4 years, 5 months ago (2016-06-30 18:08:12 UTC) #8
brettw
lgtm
4 years, 5 months ago (2016-06-30 18:24:13 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-30 19:04:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105263003/1
4 years, 5 months ago (2016-06-30 19:06:37 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 19:12:49 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 19:12:53 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 19:14:55 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7fdab8abba2415d4bd126d8a66da107b2485d2c9
Cr-Commit-Position: refs/heads/master@{#403242}

Powered by Google App Engine
This is Rietveld 408576698