Reland "Replace ICU with CED for auto encoding detection"

Reland "Replace ICU with CED for auto encoding detection"

The patch was reverted due to broken build on Windows 8 gyp.
gyp build was missing a compiler option suppressing a warning
message while gn build already handles it. crrev.com/2103793005
now fixed the issue.

This reverts commit e6ea446fa4e5628f61f35e5fe88e40cbb0d0b924.

BUG=597488
Committed: https://crrev.com/0c155762b0654045ed3031e5d1e2b447e40ca42e
Cr-Commit-Position: refs/heads/master@{#402832}

[Jinsuk Kim, 2016-06-29 05:18:13]

jinsukkim@chromium.org changed reviewers:
+ tkent@chromium.org

[tkent, 2016-06-29 05:22:04]

lgtm

[Jinsuk Kim, 2016-06-29 05:26:20]

On 2016/06/29 05:22:04, tkent wrote:
> lgtm

Thanks for the quick response!

[Jinsuk Kim, 2016-06-29 13:55:30]

The CQ bit was checked by jinsukkim@chromium.org

[commit-bot: I haz the power, 2016-06-29 13:56:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 16:14:03]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-29 16:16:40]

Description was changed from

==========
Reland "Replace ICU with CED for auto encoding detection"

The patch was reverted due to broken build on Windows 8 gyp.
gyp build was missing a compiler option suppressing a warning
message while gn build already handles it. crrev.com/2103793005
now fixed the issue.

This reverts commit e6ea446fa4e5628f61f35e5fe88e40cbb0d0b924.

BUG=597488
==========

to

==========
Reland "Replace ICU with CED for auto encoding detection"

The patch was reverted due to broken build on Windows 8 gyp.
gyp build was missing a compiler option suppressing a warning
message while gn build already handles it. crrev.com/2103793005
now fixed the issue.

This reverts commit e6ea446fa4e5628f61f35e5fe88e40cbb0d0b924.

BUG=597488

Committed: https://crrev.com/0c155762b0654045ed3031e5d1e2b447e40ca42e
Cr-Commit-Position: refs/heads/master@{#402832}
==========

[commit-bot: I haz the power, 2016-06-29 16:16:40]

Patchset 1 (id:??) landed as
https://crrev.com/0c155762b0654045ed3031e5d1e2b447e40ca42e
Cr-Commit-Position: refs/heads/master@{#402832}

[Pete Williamson, 2016-06-29 19:34:47]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2110833005/ by petewil@chromium.org.

The reason for reverting is: Sheriff is reverting this patchset on suspicion of
adding a new static constructor (string) causing a failure of the "sizes" step
of the build.

Link to broken build:
https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/21618

Relevant log lines:
FAILED linux-release-64/sizes/chrome-si/initializers: actual 9, expected 7,
better lower

We think this is ultimately coming from encodings.cc which is part of the third
party ced package, and might be related to this DEPS roll.
revert_cq: 1
revert_reason_textarea: A revert of this CL (patchset #1 id:1) has been created
in
https://codereview.chromium.org/2110853002/ by petewil@chromium.org.

The reason for reverting is: Sheriff is reverting this patchset on suspicion of
adding a new static constructor (string) causing a failure of the "sizes" step
of the build.

Link to broken build:
https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/21618

Relevant log lines:
FAILED linux-release-64/sizes/chrome-si/initializers: actual 9, expected 7,
better lower

We think this is ultimately coming from encodings.cc which is part of the third
party ced package, and might be related to this DEPS roll..