Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Unified Diff: third_party/WebKit/Source/core/html/HTMLOptGroupElement.cpp

Issue 2105243002: Remove unnecessary code from HTMLOptGroupElement. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLOptGroupElement.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/HTMLOptGroupElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLOptGroupElement.cpp b/third_party/WebKit/Source/core/html/HTMLOptGroupElement.cpp
index 09e3bd3a95c1747d75105bf2cac9ebfdae007eea..445dcf6320104355d38b653f5247cf2f58e0d5ec 100644
--- a/third_party/WebKit/Source/core/html/HTMLOptGroupElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLOptGroupElement.cpp
@@ -57,16 +57,9 @@ bool HTMLOptGroupElement::isDisabledFormControl() const
return fastHasAttribute(disabledAttr);
}
-void HTMLOptGroupElement::childrenChanged(const ChildrenChange& change)
-{
- recalcSelectOptions();
- HTMLElement::childrenChanged(change);
-}
-
void HTMLOptGroupElement::parseAttribute(const QualifiedName& name, const AtomicString& oldValue, const AtomicString& value)
{
HTMLElement::parseAttribute(name, oldValue, value);
- recalcSelectOptions();
if (name == disabledAttr) {
pseudoStateChanged(CSSSelector::PseudoDisabled);
@@ -76,13 +69,6 @@ void HTMLOptGroupElement::parseAttribute(const QualifiedName& name, const Atomic
}
}
-void HTMLOptGroupElement::recalcSelectOptions()
-{
- // TODO(tkent): Should use ownerSelectElement().
- if (HTMLSelectElement* select = Traversal<HTMLSelectElement>::firstAncestor(*this))
- select->setRecalcListItems();
-}
-
void HTMLOptGroupElement::attach(const AttachContext& context)
{
if (context.resolvedStyle) {
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLOptGroupElement.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698