Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2105243002: Remove unnecessary code from HTMLOptGroupElement. (Closed)

Created:
4 years, 5 months ago by tkent
Modified:
4 years, 5 months ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary code from HTMLOptGroupElement. * We don't need to call setRecalcListItems() in childrenChanged() because HTMLOptionElement::insertedInto() and removedFrom() do it. * We don't need to call setRecalcListItems() in parseAttribute(). OPTGROUP attributes don't affect HTMLSelectElement::m_listItems. The code exists since http://trac.webkit.org/changeset/4 . BUG=624220 Committed: https://crrev.com/8c8740e3119f92898875bbf06cb46537ac832533 Cr-Commit-Position: refs/heads/master@{#402722}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M third_party/WebKit/Source/core/html/HTMLOptGroupElement.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLOptGroupElement.cpp View 2 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
tkent
keishi, would you review this please?
4 years, 5 months ago (2016-06-29 03:24:10 UTC) #2
keishi
LGTM
4 years, 5 months ago (2016-06-29 04:44:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105243002/1
4 years, 5 months ago (2016-06-29 04:49:21 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 04:53:39 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 04:54:55 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8c8740e3119f92898875bbf06cb46537ac832533
Cr-Commit-Position: refs/heads/master@{#402722}

Powered by Google App Engine
This is Rietveld 408576698