aura: Clean up compositor initialization/destruction.

content/browser/aura/image_transport_factory.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/aura/image_transport_factory.h"
 
 #include "base/command_line.h"
 #include "content/browser/aura/gpu_process_transport_factory.h"
 #include "content/browser/aura/no_transport_image_transport_factory.h"
 #include "content/public/common/content_switches.h"
-#include "ui/compositor/compositor_setup.h"
+#include "ui/compositor/compositor.h"
+#include "ui/compositor/compositor_switches.h"
+
+#if defined(OS_CHROMEOS)
+#include "base/chromeos/chromeos_version.h"
+#endif
 
 namespace content {
 
 namespace {
 ImageTransportFactory* g_factory;
 }
 
+
+static bool UseTestContextAndTransportFactory() {
+#if defined(OS_CHROMEOS)
+  // If the test is running on the chromeos envrionment (such as
+  // device or vm bots), always use real contexts.
+  if (base::chromeos::IsRunningOnChromeOS())
+    return false;
+#endif
+
+  // Only used if the enable command line flag is used.
+  CommandLine* command_line = CommandLine::ForCurrentProcess();
+  if (!command_line->HasSwitch(switches::kTestCompositor))
+    return false;
+
+  // The disable command line flag preempts the enable flag.
+  if (!command_line->HasSwitch(switches::kDisableTestCompositor))
+    return true;
+
+  return false;
+}
+
 // static
 void ImageTransportFactory::Initialize() {
-  CommandLine* command_line = CommandLine::ForCurrentProcess();
-  if (command_line->HasSwitch(switches::kTestCompositor)) {
-    ui::SetupTestCompositor();
-  }
-  if (ui::IsTestCompositorEnabled()) {
-    g_factory = new NoTransportImageTransportFactory(
-        new ui::TestContextFactory);
+  bool use_test_contexts = UseTestContextAndTransportFactory();
+
+  if (use_test_contexts) {

[sky, 2013/08/05 16:50:58]

nit: no need for local variable here.

[danakj, 2013/08/05 16:53:34]

Done.

+    g_factory =
+        new NoTransportImageTransportFactory(new ui::TestContextFactory);
   } else {
     g_factory = new GpuProcessTransportFactory;
   }
   ui::ContextFactory::SetInstance(g_factory->AsContextFactory());
 }
 
 // static
 void ImageTransportFactory::Terminate() {
   ui::ContextFactory::SetInstance(NULL);
   delete g_factory;
   g_factory = NULL;
 }
 
 // static
 ImageTransportFactory* ImageTransportFactory::GetInstance() {
   return g_factory;
 }
 
 }  // namespace content