Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2105183003: Handle forwarding constructors (Closed)

Created:
4 years, 5 months ago by Johnni Winther
Modified:
4 years, 5 months ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Handle forwarding constructors Handle serialization of forwarding constructors that are defined by forwarding constructors: class A {} class B {} class C {} class D = A with B, C; The default constructor of D is a forwarding constructor defined by the default constructor of its super type A+B, which itself is a forwarding constructor. Thus, the defining constructor might itself be synthesized and therefore serialized indirectly. R=het@google.com Committed: https://github.com/dart-lang/sdk/commit/2f1cc9e958d4ea7cf0deb93fb62b7fceb4415327

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -7 lines) Patch
M pkg/compiler/lib/src/serialization/element_serialization.dart View 2 chunks +6 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/serialization/serialization_util.dart View 1 chunk +13 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/serialization/test_data.dart View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
4 years, 5 months ago (2016-06-29 11:00:27 UTC) #2
Harry Terkelsen
lgtm
4 years, 5 months ago (2016-06-30 16:43:23 UTC) #3
Johnni Winther
4 years, 5 months ago (2016-07-01 08:28:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2f1cc9e958d4ea7cf0deb93fb62b7fceb4415327 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698