Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 2105173004: Remove calls to MessageLoop::current() in content. (Closed)

Created:
4 years, 5 months ago by fdoray
Modified:
4 years, 5 months ago
CC:
asanka, chromium-reviews, darin-cc_chromium.org, dcheng, devtools-reviews_chromium.org, jam, jkarlin+watch_chromium.org, michaeln, mlamouri+watch-content_chromium.org, mlamouri+watch-sensors_chromium.org, mlamouri+watch-geolocation_chromium.org, Michael van Ouwerkerk, nhiroki, pfeldman, riju_, timvolodine
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to MessageLoop::current() in content. Why? The fact that there's a MessageLoop on the thread is an unnecessary implementation detail. When browser threads are migrated to base/task_scheduler, tasks will no longer have access to a MessageLoop. These changes were generated manually. BUG=616447 Committed: https://crrev.com/76388ee0f590195676606308a2666dd25ae5b4b7 Cr-Commit-Position: refs/heads/master@{#403228}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -97 lines) Patch
M content/browser/android/java/java_bridge_thread.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M content/browser/appcache/appcache_request_handler_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/appcache/appcache_response_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/appcache/appcache_storage_impl_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/appcache/appcache_url_request_job_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/device_sensors/data_fetcher_shared_memory_base_unittest.cc View 6 chunks +11 lines, -5 lines 0 comments Download
M content/browser/device_sensors/data_fetcher_shared_memory_mac.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M content/browser/download/drag_download_file.h View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/download/drag_download_file.cc View 9 chunks +18 lines, -20 lines 0 comments Download
M content/browser/gamepad/gamepad_provider.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/geolocation/geolocation_provider_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/geolocation/geolocation_provider_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/child_process.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/child/child_thread_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/ppapi_plugin/ppapi_thread.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/devtools/devtools_agent.cc View 2 chunks +15 lines, -8 lines 0 comments Download
M content/renderer/devtools/devtools_agent_filter.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/renderer/devtools/devtools_agent_filter.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M content/renderer/p2p/ipc_socket_factory.cc View 15 chunks +21 lines, -21 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
fdoray
Can you review this CL? Thanks.
4 years, 5 months ago (2016-06-29 17:29:50 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 5 months ago (2016-06-30 15:14:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105173004/1
4 years, 5 months ago (2016-06-30 17:24:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 18:29:15 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 18:29:33 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/76388ee0f590195676606308a2666dd25ae5b4b7 Cr-Commit-Position: refs/heads/master@{#403228}
4 years, 5 months ago (2016-06-30 18:30:49 UTC) #9
kelvinp
4 years, 5 months ago (2016-06-30 20:24:32 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2116643002/ by kelvinp@chromium.org.

The reason for reverting is: Failed Browser tests and webkit tests.

Browser tests failed:
DevToolsSanityTest.AutoAttachToWindowOpen
https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%2...

webkit tests failed:
inspector/sources/debugger-pause/debugger-pause-on-promise-rejection.html
inspector/sources/debugger/live-edit-no-reveal.html
inspector/sources/debugger-step/debugger-step-out-document-write.html
inspector/sources/debugger-step/debugger-step-over-inlined-scripts.html
inspector/sources/debugger-console/debug-console-command.html
inspector/sources/debugger-frameworks/frameworks-sourcemap.html
inspector-protocol/debugger/debugger-doesnt-step-into-injected-script.html
inspector/sources/debugger-step/debugger-step-over-document-write.html
inspector/sources/debugger-step/debugger-step-out-event-listener.html
inspector/sources/debugger-console/debugger-command-line-api.html
inspector/sources/debugger-step/debugger-step-into-event-listener.html
inspector/sources/debugger-breakpoints/dom-breakpoints.html
inspector/sources/debugger/debugger-return-value.html
inspector/sources/debugger-ui/debugger-inline-values.html
inspector/sources/debugger-ui/reveal-not-skipped.html
inspector-protocol/debugger/stepping-with-blackboxed-ranges.html
inspector/sources/debugger-step/debugger-step-in.html
inspector/sources/debugger-frameworks/frameworks-skip-step-in.html
inspector/sources/debugger-step/debugger-step-into-across-timeouts.html
inspector/sources/debugger-frameworks/frameworks-step-from-framework.html
inspector/sources/debugger-step/debugger-step-into-custom-element-callbacks.html
inspector/sources/debugger-pause/debugger-eval-while-paused-throws.html
inspector/sources/debugger/mutation-observer-suspend-while-paused.html
inspector/sources/debugger-frameworks/frameworks-dom-xhr-event-breakpoints.html
inspector-protocol/debugger/postMessage-on-pause.html
inspector/sources/debugger-frameworks/frameworks-step-into-skips-setTimeout.html
inspector/sources/debugger/live-edit.html
inspector/sources/debugger-frameworks/frameworks-steppings.html
inspector-protocol/debugger/continueToLocation.html
inspector/sources/debugger-pause/debugger-eval-on-call-frame-inside-iframe.html
inspector/sources/debugger-step/debugger-step-into-document-write.html
inspector-protocol/debugger/updateCallFrameScopes.html
inspector/sources/debugger-step/debugger-step-over.html
inspector/sources/debugger-frameworks/frameworks-jquery.html
inspector-protocol/debugger/debugger-setBlackboxPatterns.html
inspector/sources/debugger-step/debugger-step-into-inlined-scripts.html
inspector/sources/debugger-step/debugger-step-over-across-timeouts.html
inspector/sources/debugger-step/debugger-step-through-promises.html
inspector/sources/debugger-step/debugger-step-out-custom-element-callbacks.html
inspector-protocol/debugger/step-over-caught-exception.html

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11/build....

Powered by Google App Engine
This is Rietveld 408576698