Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1312)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2105173002: Add enum-based UMA reporting to automatic redirect logic of Offline Pages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed feedback Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 9ad3b5ef328b87ac7c2f66dbbebb6d8f7656277a..8fe6681aa4141a651d37c605e54681f3a5c47428 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -35862,7 +35862,17 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<summary>Size of the saved copy of an offline page.</summary>
</histogram>
+<histogram name="OfflinePages.RedirectResult" enum="OfflinePagesRedirectResult">
+ <owner>dimich@chromium.org</owner>
+ <summary>
+ Result of automatic redirect to offline version of the page or back.
+ </summary>
+</histogram>
+
<histogram name="OfflinePages.RedirectToOfflineCount" units="count">
+ <obsolete>
+ Deprecated 6/2016. Refactored into OfflinePages.RedirectResult.
+ </obsolete>
<owner>jianli@chromium.org</owner>
<summary>
Number of times an offline copy was loaded instead when the user is trying
@@ -35872,6 +35882,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</histogram>
<histogram name="OfflinePages.RedirectToOnlineCount" units="count">
+ <obsolete>
+ Deprecated 6/2016. Refactored into OfflinePages.RedirectResult.
+ </obsolete>
<owner>jianli@chromium.org</owner>
<summary>
Number of times an online version was loaded instead when the user is trying
@@ -35928,6 +35941,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</histogram>
<histogram name="OfflinePages.ShowOfflinePageOnBadNetwork" enum="Boolean">
+ <obsolete>
+ Deprecated 6/2016. Refactored into OfflinePages.RedirectResult.
+ </obsolete>
<owner>jianli@chromium.org</owner>
<summary>
Whether an offline page is shown, instead of error page, when the network is
@@ -83787,6 +83803,19 @@ To add a new entry, add it with any value and run test to compute valid value.
<int value="3" label="Data parsing failed"/>
</enum>
+<enum name="OfflinePagesRedirectResult" type="int">
+ <int value="0" label="Redirected on disconnected network"/>
+ <int value="1" label="Page not found on disconnected network"/>
+ <int value="2" label="Redirected on flaky network"/>
+ <int value="3" label="Page not found on flaky network"/>
+ <int value="4" label="Ignored flaky network f/b"/>
fgorski 2016/06/29 17:01:16 expand f/b
Dmitry Titov 2016/06/29 18:25:45 Done.
+ <int value="5" label="Connected network"/>
fgorski 2016/06/29 17:01:16 Redirected on connected network
Dmitry Titov 2016/06/29 18:25:45 Done.
+ <int value="6" label="No Android Tab found"/>
fgorski 2016/06/29 17:01:16 No tab ID found?
Dmitry Titov 2016/06/29 18:25:45 Done.
+ <int value="7" label="Show net error page"/>
fgorski 2016/06/29 17:01:16 Showing error page with no redirection path ?
Dmitry Titov 2016/06/29 18:25:46 Done, used "Unknown net error, showing error page"
+ <int value="8" label="Redirect loop offline"/>
+ <int value="9" label="Redirect loop online"/>
+</enum>
+
<enum name="OfflinePagesSavePageResult" type="int">
<int value="0" label="Success"/>
<int value="1" label="Cancelled"/>

Powered by Google App Engine
This is Rietveld 408576698