tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 9ad3b5ef328b87ac7c2f66dbbebb6d8f7656277a..57af6d32fd939e4bd5e72afe4fbc1dad7926e383 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -35862,7 +35862,17 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   <summary>Size of the saved copy of an offline page.</summary>
 </histogram>
 
+<histogram name="OfflinePages.RedirectResult" enum="OfflinePagesRedirectResult">
+  <owner>dimich@chromium.org</owner>
+  <summary>
+    Result of automatic redirect to offline version of the page or back.

[Mark P, 2016/06/29 19:18:27]

It would be nice to say roughly when this is emitted.  I somewhat get the
impression from the enum comment that you might be able to say:
"Emitted to exactly once when an offline page is attempted to be shown."

[Dmitry Titov, 2016/06/29 20:27:42]

Done.

+  </summary>
+</histogram>
+
 <histogram name="OfflinePages.RedirectToOfflineCount" units="count">
+  <obsolete>
+    Deprecated 6/2016. Refactored into OfflinePages.RedirectResult.
+  </obsolete>
   <owner>jianli@chromium.org</owner>
   <summary>
     Number of times an offline copy was loaded instead when the user is trying
@@ -35872,6 +35882,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
 </histogram>
 
 <histogram name="OfflinePages.RedirectToOnlineCount" units="count">
+  <obsolete>
+    Deprecated 6/2016. Refactored into OfflinePages.RedirectResult.
+  </obsolete>
   <owner>jianli@chromium.org</owner>
   <summary>
     Number of times an online version was loaded instead when the user is trying
@@ -35928,6 +35941,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
 </histogram>
 
 <histogram name="OfflinePages.ShowOfflinePageOnBadNetwork" enum="Boolean">
+  <obsolete>
+    Deprecated 6/2016. Refactored into OfflinePages.RedirectResult.
+  </obsolete>
   <owner>jianli@chromium.org</owner>
   <summary>
     Whether an offline page is shown, instead of error page, when the network is
@@ -83787,6 +83803,19 @@ To add a new entry, add it with any value and run test to compute valid value.
   <int value="3" label="Data parsing failed"/>
 </enum>
 
+<enum name="OfflinePagesRedirectResult" type="int">
+  <int value="0" label="Redirected on disconnected network"/>
+  <int value="1" label="Page not found on disconnected network"/>
+  <int value="2" label="Redirected on flaky network"/>
+  <int value="3" label="Page not found on flaky network"/>
+  <int value="4" label="Ignored flaky network forward/back"/>
+  <int value="5" label="Redirected on connected network"/>
+  <int value="6" label="No Tab Id found"/>

[Mark P, 2016/06/29 19:18:27]

While I can understand the other labels, I don't understand this one.  Is there
a clearer way to explain it?

[Dmitry Titov, 2016/06/29 20:27:42]

Done.

We use Android Tab persistent ID to guard for privacy, so in addition to tests
we'd like to know if this will ever be not 0. This is the only reason to have it
here reported, otherwise it'd be in 'fringe' category.

+  <int value="7" label="Unknown net error, showing error page"/>
+  <int value="8" label="Redirect loop offline"/>
+  <int value="9" label="Redirect loop online"/>
+</enum>
+
 <enum name="OfflinePagesSavePageResult" type="int">
   <int value="0" label="Success"/>
   <int value="1" label="Cancelled"/>