tools/metrics/histograms/histograms.xml - Issue 2105173002: Add enum-based UMA reporting to automatic redirect logic of Offline Pages.

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2105173002: Add enum-based UMA reporting to automatic redirect logic of Offline Pages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

« chrome/browser/android/offline_pages/offline_page_tab_helper.cc ('K') | « chrome/browser/android/offline_pages/offline_page_tab_helper_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 9ad3b5ef328b87ac7c2f66dbbebb6d8f7656277a..dd71b85b35b5467795a1df34336d5e378bcfd0f2 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -35862,21 +35862,10 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

<summary>Size of the saved copy of an offline page.</summary>

</histogram>

-<histogram name="OfflinePages.RedirectToOfflineCount" units="count">

- <owner>jianli@chromium.org</owner>

jianli 2016/06/29 00:19:30 You should mark this as obsolete instead of removi

Dmitry Titov 2016/06/29 01:51:31 Done.

- <summary>

- Number of times an offline copy was loaded instead when the user is trying

- to load the online version of a saved page and there is no network

- connection.

- </summary>

-</histogram>

-<histogram name="OfflinePages.RedirectToOnlineCount" units="count">

- <owner>jianli@chromium.org</owner>

+<histogram name="OfflinePages.RedirectResult" enum="OfflinePagesRedirectResult">

+ <owner>dimich@chromium.org</owner>

- Number of times an online version was loaded instead when the user is trying

- to load the offline copy of a saved page and there is network connection.

- connection.

+ Result of automatic redirect to offline version of the page or back.

</summary>

</histogram>

@@ -35927,14 +35916,6 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

<summary>Whether a shared page was an offline page or not.</summary>

</histogram>

-<histogram name="OfflinePages.ShowOfflinePageOnBadNetwork" enum="Boolean">

- <owner>jianli@chromium.org</owner>

- <summary>

- Whether an offline page is shown, instead of error page, when the network is

- disconnected or poor condition.

- </summary>

-</histogram>

<owner>fgorski@chromium.org</owner>

<owner>jianli@chromium.org</owner>

@@ -83787,6 +83768,18 @@ To add a new entry, add it with any value and run test to compute valid value.

</enum>

+<enum name="OfflinePagesRedirectResult" type="int">

+ <int value="0" label="Disconnected network"/>

+ <int value="1" label="Disconnected network page not found"/>

+ <int value="2" label="Flaky network"/>

+ <int value="3" label="Flaky network page not found"/>

+ <int value="4" label="Flaky network f/b"/>

+ <int value="5" label="Flaky network f/b page not found"/>

+ <int value="6" label="Connected network"/>

+ <int value="7" label="No Android Tab found"/>

+ <int value="8" label="Show net error page"/>

+</enum>