Fix initialization ordering in GLES2CmdDecoder.

Fix initialization ordering in GLES2CmdDecoder.

The ContextGroup must be initialized before feature flag checks will work
correctly.

BUG=602484
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/477e47082e76afca7c2e656a0714ee24e67fb702
Cr-Commit-Position: refs/heads/master@{#404019}

[erikchen, 2016-06-28 22:31:23]

Description was changed from

==========
Fix initialization ordering in GLES2CmdDecoder.

The ContextGroup must be initialized before feature flag checks will work
correctly.

BUG=602484
==========

to

==========
Fix initialization ordering in GLES2CmdDecoder.

The ContextGroup must be initialized before feature flag checks will work
correctly.

BUG=602484
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[erikchen, 2016-06-28 22:33:31]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[erikchen, 2016-06-28 22:34:25]

erikchen@chromium.org changed reviewers:
+ piman@chromium.org

[erikchen, 2016-06-28 22:34:26]

piman: Please review.

[commit-bot: I haz the power, 2016-06-28 22:36:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[piman, 2016-06-28 23:07:33]

https://codereview.chromium.org/2105153002/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/2105153002/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/gles2_cmd_decoder.cc:2991: group_ = NULL;  // Must
not destroy ContextGroup if it is not initialized.
group_ is initialized at this point, so this line should be removed.

[commit-bot: I haz the power, 2016-06-29 02:04:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-29 02:04:41]

Dry run: This issue passed the CQ dry run.

[erikchen, 2016-07-06 21:32:10]

piman: PTAL

https://codereview.chromium.org/2105153002/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/2105153002/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/gles2_cmd_decoder.cc:2991: group_ = NULL;  // Must
not destroy ContextGroup if it is not initialized.
On 2016/06/28 23:07:33, piman OOO back 2016-7-6 wrote:
> group_ is initialized at this point, so this line should be removed.

Done.

[piman, 2016-07-06 21:34:30]

lgtm

[erikchen, 2016-07-06 21:36:51]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2016-07-06 21:37:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 00:39:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-07 00:39:24]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-07 00:42:21]

Description was changed from

==========
Fix initialization ordering in GLES2CmdDecoder.

The ContextGroup must be initialized before feature flag checks will work
correctly.

BUG=602484
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix initialization ordering in GLES2CmdDecoder.

The ContextGroup must be initialized before feature flag checks will work
correctly.

BUG=602484
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/477e47082e76afca7c2e656a0714ee24e67fb702
Cr-Commit-Position: refs/heads/master@{#404019}
==========

[commit-bot: I haz the power, 2016-07-07 00:42:22]

Patchset 2 (id:??) landed as
https://crrev.com/477e47082e76afca7c2e656a0714ee24e67fb702
Cr-Commit-Position: refs/heads/master@{#404019}

[phoglund_chromium, 2016-07-07 09:23:30]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2126183002/ by phoglund@chromium.org.

The reason for reverting is: Appears to break GPU webkit tests on Mac and Linux.
This revert is a bit speculative since there are like 4 more gpu-related patches
in the blame list, but the error messages does mention gles2_cmd_decoder.cc, so
picking this patch as the first victim.
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds...
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20ASAN/b....