Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 2105123002: various: Change auto to not deduce raw pointers. (Closed)

Created:
4 years, 5 months ago by vmpstr
Modified:
4 years, 5 months ago
CC:
chromium-reviews, chromoting-reviews_chromium.org, mlamouri+watch-notifications_chromium.org, Peter Beverloo
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

various: Change auto to not deduce raw pointers. This patch updates the code to prevent auto deducing to a raw pointer. R=danakj, dcheng BUG=554600 Committed: https://crrev.com/981aa5a100145aee038661b81db780edbb257a09 Cr-Commit-Position: refs/heads/master@{#405377}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M remoting/protocol/webrtc_transport.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/catalog/reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/tracing/tracing_app.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/skia_memory_dump_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M skia/ext/skia_trace_memory_dump_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M storage/browser/quota/usage_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/render_text_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/message_center/message_center_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M url/origin_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M url/scheme_host_port_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 28 (10 generated)
vmpstr
Please take a look.
4 years, 5 months ago (2016-06-28 21:40:51 UTC) #3
Wez
wez->sergeyu
4 years, 5 months ago (2016-06-28 22:06:57 UTC) #5
danakj
LGTM
4 years, 5 months ago (2016-06-28 22:07:32 UTC) #6
sky
I assume you're asking me for services/shell? LGTM
4 years, 5 months ago (2016-06-28 22:17:11 UTC) #7
Elliot Glaysher
lgtm
4 years, 5 months ago (2016-06-28 22:18:58 UTC) #8
vmpstr
On 2016/06/28 22:17:11, sky wrote: > I assume you're asking me for services/shell? LGTM Err ...
4 years, 5 months ago (2016-06-28 22:28:48 UTC) #9
Ken Rockot(use gerrit already)
lgtm
4 years, 5 months ago (2016-06-28 22:30:02 UTC) #10
sky
SLGTM
4 years, 5 months ago (2016-06-28 22:31:23 UTC) #11
Sergey Ulanov
lgtm
4 years, 5 months ago (2016-06-28 23:54:40 UTC) #12
f(malita)
lgtm
4 years, 5 months ago (2016-06-29 03:09:29 UTC) #13
vmpstr
+brettw for url/. Please take a look.
4 years, 5 months ago (2016-07-13 20:37:02 UTC) #15
brettw
url lgtm
4 years, 5 months ago (2016-07-13 20:42:36 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105123002/1
4 years, 5 months ago (2016-07-13 21:01:39 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/35382) ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 5 months ago (2016-07-13 21:06:10 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105123002/20001
4 years, 5 months ago (2016-07-13 23:46:42 UTC) #23
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-14 01:05:22 UTC) #25
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 01:05:26 UTC) #26
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 01:08:07 UTC) #28
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/981aa5a100145aee038661b81db780edbb257a09
Cr-Commit-Position: refs/heads/master@{#405377}

Powered by Google App Engine
This is Rietveld 408576698