Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2105113002: add annotations to debugger (Closed)

Created:
4 years, 5 months ago by reed1
Modified:
4 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 6

Patch Set 2 : tested this time #

Patch Set 3 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -0 lines) Patch
M tools/debugger/SkDebugCanvas.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/debugger/SkDebugCanvas.cpp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M tools/debugger/SkDrawCommand.h View 1 2 2 chunks +16 lines, -0 lines 0 comments Download
M tools/debugger/SkDrawCommand.cpp View 1 2 3 chunks +37 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
reed1
4 years, 5 months ago (2016-06-28 21:14:22 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105113002/20001
4 years, 5 months ago (2016-06-28 21:29:51 UTC) #5
robertphillips
lgtm https://codereview.chromium.org/2105113002/diff/1/tools/debugger/SkDrawCommand.cpp File tools/debugger/SkDrawCommand.cpp (right): https://codereview.chromium.org/2105113002/diff/1/tools/debugger/SkDrawCommand.cpp#newcode1731 tools/debugger/SkDrawCommand.cpp:1731: You can just remove this override from this ...
4 years, 5 months ago (2016-06-28 21:30:37 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-28 21:49:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105113002/20001
4 years, 5 months ago (2016-06-29 01:08:24 UTC) #10
reed1
https://codereview.chromium.org/2105113002/diff/1/tools/debugger/SkDrawCommand.cpp File tools/debugger/SkDrawCommand.cpp (right): https://codereview.chromium.org/2105113002/diff/1/tools/debugger/SkDrawCommand.cpp#newcode1731 tools/debugger/SkDrawCommand.cpp:1731: On 2016/06/28 21:30:37, robertphillips wrote: > You can just ...
4 years, 5 months ago (2016-06-29 01:40:00 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105113002/40001
4 years, 5 months ago (2016-06-29 01:40:16 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 01:54:23 UTC) #17
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/97660ccbd10d83a2bb1fa88c672d17132649efef

Powered by Google App Engine
This is Rietveld 408576698