Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Issue 2105103002: Minor change to the uWeave packet generator to allow inheritance (Closed)

Created:
4 years, 5 months ago by jingxuy
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Current generator's functions are not virtual and doesn't allow the subclass to have polymorphism for the mocks in the test. This CL makes those functions virtual and overridable. BUG=617238 Committed: https://crrev.com/15d29c37855d219d1d015a01639a3ac9c00fda1c Cr-Commit-Position: refs/heads/master@{#402673}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M components/proximity_auth/ble/bluetooth_low_energy_weave_packet_generator.h View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
jingxuy
4 years, 5 months ago (2016-06-28 21:14:31 UTC) #3
Kyle Horimoto
Jing, please make your CL descriptions more in-depth and understandable. As I've said before, your ...
4 years, 5 months ago (2016-06-28 21:16:43 UTC) #4
jingxuy
4 years, 5 months ago (2016-06-28 21:22:17 UTC) #6
Kyle Horimoto
lgtm
4 years, 5 months ago (2016-06-28 21:25:45 UTC) #7
Tim Song
lgtm
4 years, 5 months ago (2016-06-28 23:46:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105103002/1
4 years, 5 months ago (2016-06-28 23:56:38 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 02:27:04 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 02:30:25 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/15d29c37855d219d1d015a01639a3ac9c00fda1c
Cr-Commit-Position: refs/heads/master@{#402673}

Powered by Google App Engine
This is Rietveld 408576698