Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 2105063003: Dump all stacks, plus main one, during Windows minidump symbolization. (Closed)

Created:
4 years, 5 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 5 months ago
Reviewers:
nednguyen
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org, vmiura, eyaich
Base URL:
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Dump all stacks, plus main one, during Windows minidump symbolization. Second attempt. The first one neglected to dump the stack from the crashed thread's exception context record, leading to imprecise stack traces for the crashed thread, and failures of stacktrace_unittest. BUG=chromium:609252 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/6b80601a33938016ef66f7f4ce697e53dbdca701

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Ken Russell (switch to Gerrit)
Ned: please review. Thanks. Tested with the isolate from https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/246705 and verified that the test ...
4 years, 5 months ago (2016-06-29 00:29:16 UTC) #2
nednguyen
lgtm
4 years, 5 months ago (2016-06-29 01:35:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105063003/1
4 years, 5 months ago (2016-06-29 01:35:17 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 02:20:30 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698