Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Issue 2105043003: Flip full, perf Mac and Win builders back to GYP. (Closed)

Created:
4 years, 5 months ago by Dirk Pranke
Modified:
4 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Flip full, perf Mac and Win builders back to GYP. This will give us a bit more test coverage prior to the branch. R=brettw@chromium.org BUG=618468, 605318 Committed: https://crrev.com/1286dbd329b0669e082ffcebe3cb2b7fa47e438d Cr-Commit-Position: refs/heads/master@{#402631}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M tools/mb/mb_config.pyl View 6 chunks +16 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105043003/1
4 years, 5 months ago (2016-06-28 23:48:58 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 5 months ago (2016-06-28 23:48:59 UTC) #4
brettw
lgtm
4 years, 5 months ago (2016-06-29 00:02:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105043003/1
4 years, 5 months ago (2016-06-29 00:05:45 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 01:43:43 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 01:45:39 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1286dbd329b0669e082ffcebe3cb2b7fa47e438d
Cr-Commit-Position: refs/heads/master@{#402631}

Powered by Google App Engine
This is Rietveld 408576698