extensions/renderer/extension_frame_helper.h - Issue 2105033003: tabId support to chrome.extensions.getViews()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/extension_frame_helper.h

Issue 2105033003: tabId support to chrome.extensions.getViews() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed code review Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/extension_frame_helper.h

diff --git a/extensions/renderer/extension_frame_helper.h b/extensions/renderer/extension_frame_helper.h

index a248edae75b0bbf8b41619e2c75788bbf64d3a18..5b30a0d4860ace5057a69b17c1e7b2d51aaa9cb3 100644

--- a/extensions/renderer/extension_frame_helper.h

+++ b/extensions/renderer/extension_frame_helper.h

@@ -42,6 +42,7 @@ class ExtensionFrameHelper

static std::vector<content::RenderFrame*> GetExtensionFrames(

const std::string& extension_id,

int browser_window_id,

+ int tab_id,

ViewType view_type);

// Returns the main frame of the extension's background page, or null if there