tabId support to chrome.extensions.getViews()

extensions/renderer/runtime_custom_bindings.cc

Index: extensions/renderer/runtime_custom_bindings.cc
diff --git a/extensions/renderer/runtime_custom_bindings.cc b/extensions/renderer/runtime_custom_bindings.cc
index 6efae5f182d9f925e92b55ad91cb6328439206e5..d5221f45f83a8b1ca5b7bd627ac324e8f60cf3c6 100644
--- a/extensions/renderer/runtime_custom_bindings.cc
+++ b/extensions/renderer/runtime_custom_bindings.cc
@@ -107,13 +107,15 @@ void RuntimeCustomBindings::GetManifest(
 
 void RuntimeCustomBindings::GetExtensionViews(
     const v8::FunctionCallbackInfo<v8::Value>& args) {
-  CHECK_EQ(args.Length(), 2);
+  CHECK_EQ(args.Length(), 3);
   CHECK(args[0]->IsInt32());
   CHECK(args[1]->IsString());
+  CHECK(args[2]->IsInt32());

[Devlin, 2016/07/11 17:23:45]

ditto re parameter ordering.

[Devlin, 2016/07/12 18:35:57]

Looks like this one wasn't addressed?

[Devlin, 2016/07/13 16:22:58]

This one still wasn't done. :)

[catmullings, 2016/07/13 22:07:05]

Done.

 
   // |browser_window_id| == extension_misc::kUnknownWindowId means getting
   // all views for the current extension.
   int browser_window_id = args[0]->Int32Value();
+  int tab_id = args[2]->Int32Value();
 
   std::string view_type_string =
       base::ToUpperASCII(*v8::String::Utf8Value(args[1]));
@@ -144,7 +146,7 @@ void RuntimeCustomBindings::GetExtensionViews(
 
   std::vector<content::RenderFrame*> frames =
       ExtensionFrameHelper::GetExtensionFrames(extension_id, browser_window_id,
-                                               view_type);
+                                               view_type, tab_id);
   v8::Local<v8::Context> v8_context = args.GetIsolate()->GetCurrentContext();
   v8::Local<v8::Array> v8_views = v8::Array::New(args.GetIsolate());
   int v8_index = 0;