extensions/renderer/resources/app_window_custom_bindings.js - Issue 2105033003: tabId support to chrome.extensions.getViews()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/resources/app_window_custom_bindings.js

Issue 2105033003: tabId support to chrome.extensions.getViews() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Minor followup to patch 5 Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/resources/app_window_custom_bindings.js

diff --git a/extensions/renderer/resources/app_window_custom_bindings.js b/extensions/renderer/resources/app_window_custom_bindings.js

index b0ae54f4a7b3e8bef8de664864edcc8d6bdfd008..546183f8428a3a87eeb050c109037960c7961228 100644

--- a/extensions/renderer/resources/app_window_custom_bindings.js

+++ b/extensions/renderer/resources/app_window_custom_bindings.js

@@ -185,7 +185,7 @@ appWindow.registerCustomHook(function(bindingsAPI) {

});

apiFunctions.setHandleRequest('getAll', function() {

- var views = runtimeNatives.GetExtensionViews(-1, 'APP_WINDOW');

+ var views = runtimeNatives.GetExtensionViews(-1, -1, 'APP_WINDOW');

return $Array.map(views, function(win) {

return win.chrome.app.window.current();

});