Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: chrome/renderer/resources/extensions/browser_action_custom_bindings.js

Issue 2105033003: tabId support to chrome.extensions.getViews() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed code review Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Custom binding for the browserAction API. 5 // Custom binding for the browserAction API.
6 6
7 var binding = require('binding').Binding.create('browserAction'); 7 var binding = require('binding').Binding.create('browserAction');
8 8
9 var setIcon = require('setIcon').setIcon; 9 var setIcon = require('setIcon').setIcon;
10 var getExtensionViews = requireNative('runtime').GetExtensionViews; 10 var getExtensionViews = requireNative('runtime').GetExtensionViews;
(...skipping 10 matching lines...) Expand all
21 }); 21 });
22 22
23 apiFunctions.setCustomCallback('openPopup', 23 apiFunctions.setCustomCallback('openPopup',
24 function(name, request, callback, response) { 24 function(name, request, callback, response) {
25 if (!callback) 25 if (!callback)
26 return; 26 return;
27 27
28 if (lastError.hasError(chrome)) { 28 if (lastError.hasError(chrome)) {
29 callback(); 29 callback();
30 } else { 30 } else {
31 var views = getExtensionViews(-1, 'POPUP'); 31 var views = getExtensionViews(-1, 'POPUP', -1);
32 callback(views.length > 0 ? views[0] : null); 32 callback(views.length > 0 ? views[0] : null);
33 } 33 }
34 }); 34 });
35 }); 35 });
36 36
37 exports.$set('binding', binding.generate()); 37 exports.$set('binding', binding.generate());
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698